packs update adds todos for strict violations

[perryqh]

"Bug"

Running pks update will add meaningless "todo" entries for strict violations. pks check behaves as expected in that it detects/reports strict errors regardless of what is in todo files.

Proposed Change:

• pks update to no longer update todos with strict violations
• pks update outputs skipped strict violations so that the user can expect a pks check error.
• pks check remains unchanged

How?

Add a new strict_mode bool to the ViolationIdentifier struct. It will be populated in the "checkers" and be used to ignore violations when writing out todos and detecting strict_mode violations.

Instead of a strict_mode bool we could also consider an enum. I'm not sure if the complexity is warranted at this time.

Packwerk

As an aside, packwerk will not update todo files with strict violations and will also not report packwerk check strict violations if they have a corresponding todo entry. Supporting pks check ignoring strict todo violations is outside the scope of this issue.

Feedback

Thoughts? Better approaches?

[alexevanczuk]

Bool on the violation identifier sounds great! As you mentioned we can easily refactor to an enum later if needed.

Thank you!!

[perryqh]

Fixed with https://github.com/alexevanczuk/packs/releases/tag/v0.1.89