Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM emulator does not support thumb mode #6

Closed
wbokslag opened this issue Mar 8, 2018 · 1 comment
Closed

ARM emulator does not support thumb mode #6

wbokslag opened this issue Mar 8, 2018 · 1 comment

Comments

@wbokslag
Copy link

wbokslag commented Mar 8, 2018

Hi,

Thanks for your great plugin, it's very useful. However, it does not properly emulate ARM in thumb mode. In order to fix this, the following line should be added to the start of step_thread_main()

if get_arch()[0:3] == "arm" and GetReg(self.pc, "T"):
    self.pc |= 1

Possibly, it would be a good idea to store get_arch() in a class variable, as it is now frequently computed while it is a constant value. This negatively impacts emulation speed.

Kind regards,

Wouter

@alexhude
Copy link
Owner

alexhude commented Mar 8, 2018

Yep, I know, and it is not that simple, there are some corner cases. I am working on update.

alexhude added a commit that referenced this issue Mar 11, 2018
- Menu system rewritten to be more generic
- Fix ARM emulation in thumb mode (#6)
- Fix context restore for memory breakpoint workaround (#5)
- Rename gloabal variables to avoid collisions with other plugins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants