Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make all colors dark/light mode aware #71

Closed
tronta opened this issue Sep 21, 2022 · 2 comments
Closed

make all colors dark/light mode aware #71

tronta opened this issue Sep 21, 2022 · 2 comments

Comments

@tronta
Copy link
Contributor

tronta commented Sep 21, 2022

currently only black (white) is only dark/light mode aware.

It would be great to have all colors be mode aware.

Proposal:
Define for the light mode a set of dark colors (maybe remove yellow, at it is not really visible) on white background.
Then define for each color a lighter version for the dark mode (maybe it is not needed for medium bright colors)

With this, one could switch between the different modes, without adjusting the colors of the plots.

@alexhuntley
Copy link
Owner

Thanks for the suggestion. I implemented this in 022efe9. I kept the yellow in the end, but using a darker shade, so it should be visible enough on the light background.

@tronta
Copy link
Contributor Author

tronta commented Sep 25, 2022

Looks nice. Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants