Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-pages-publish repository parameter #39

Closed
Leefrost opened this issue Apr 25, 2017 · 3 comments
Closed

Gh-pages-publish repository parameter #39

Leefrost opened this issue Apr 25, 2017 · 3 comments

Comments

@Leefrost
Copy link
Contributor

Hi,
I got a problem when I tested some features of library-starter. Problem is in this line in file tools/gh-page-publish.js:

let repository = url.parse(pkg.repository)

But config file contains a little bit different node:

"repository": { "type": "git", "url": "https://someurlhere.git" }

So maybe we should parse pkg.repository.url? Or i miss something during installation process :(

@alexjoverm
Copy link
Owner

Hi @Leefrost, you're totally right about this!

A good thing, could be to check whether pkg.repository is a string or an object, since the repository key can be written in a shorthand way (just the string).

Would you be able to make a PR for this?

@Leefrost
Copy link
Contributor Author

Hi @alexjoverm! Here is my pull request

@alexjoverm
Copy link
Owner

Closed as per #44, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants