Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify reference to all_equal function #356

Open
alexmojaki opened this issue Jun 18, 2022 · 1 comment
Open

Clarify reference to all_equal function #356

alexmojaki opened this issue Jun 18, 2022 · 1 comment

Comments

@alexmojaki
Copy link
Owner

https://poeditor.com/projects/po_edit?id=490053&term=344292569&id_language=50#showComments344292569

A French user report this : "Il serait préférable de ne pas citer la fonction tous_egaux à ce moment là de l’exercice car elle n’est pas exploitable. La seconde solution donnée en fin d’exercice ne marche pas, car la fonction tous_egaux n’est pas définie." Could you check where could be the issue ; it seems all about all_equal is translated...

Hmmm, this is a fair point. all_equal was written two pages earlier. Users may skip to this page directly, or they may have just forgotten about it. Besides that, assert_equal gets special treatment and is always defined, so they may expect the same for all_equal and be surprised by getting an error. I think when this content was written the first time, this might have been less of an issue.

I think encouraging reuse of functions and connecting to previous learning is good, but maybe the text should make it clearer what all_equal is referring to (e.g. with a link to the page) and make it clear that it's not required to solve the current exercise.

@alexmojaki
Copy link
Owner Author

alexmojaki commented Jun 18, 2022

https://poeditor.com/projects/po_edit?id=490053&term=344292869&id_language=50#showComments344292869

A French user report :
"NameError: name 'tous_egaux' is not defined"
when used in diagonal check, this is curious
Is it possible all_equal doesn't use code.bit in this case ?

Same confusion, all_equal is not magically defined in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant