Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Wrong return of IsoCountryCodes.for_select in 0.7.2 #30

Closed
AKovtunov opened this issue Oct 2, 2015 · 10 comments
Closed

Wrong return of IsoCountryCodes.for_select in 0.7.2 #30

AKovtunov opened this issue Oct 2, 2015 · 10 comments

Comments

@AKovtunov
Copy link

Good day, I'm using your library and after release of 0.7.2 version
IsoCountryCodes.for_select returns

 ["Virgin Islands (U.S.)", "VI"],
 ["Wallis and Futuna", "WF"],
 ["Western Sahara", "EH"],
 ["Yemen", "YE"],
 ["Zambia", "ZM"],
 ["Zimbabwe", "ZW"],
 [nil, nil]]

nil values at the end.

Reverted back to 0.7.1 and this problem has gone. Can someone else prove it? Is it a valid output?

@greysteil
Copy link
Collaborator

@AKovtunov you're totally right, and this is my bad - I made a typo in #29. Fixed in 77c993c, and I've also added a spec to ensure this can't recur.

@alexrabarts probably worth a patch release.

@ur5us
Copy link

ur5us commented Nov 5, 2015

@alexrabarts @greysteil Yes please, just ran into the same issue.

@ur5us
Copy link

ur5us commented Dec 17, 2015

@alexrabarts Ping

@alexrabarts
Copy link
Owner

Sorry for the delay in getting this released. I just pushed out 0.7.3.

@greysteil
Copy link
Collaborator

Thanks @alexrabarts. Can you add me on Rubygems?

@alexrabarts
Copy link
Owner

@greysteil Sure - I'll do that now.

@greysteil
Copy link
Collaborator

❤️

@alexrabarts
Copy link
Owner

Done and Merry Christmas! We should meet up at #TechspaceConnect at some point @greysteil

@AKovtunov
Copy link
Author

I'm still receiving your lovely comments, guys 😄

@greysteil
Copy link
Collaborator

Ha, sorry @AKovtunov. @alexrabarts - indeed, let me know next time you're going!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants