Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NETCore 2.0 build #6

Closed
shar0119 opened this issue Feb 9, 2018 · 3 comments
Closed

.NETCore 2.0 build #6

shar0119 opened this issue Feb 9, 2018 · 3 comments

Comments

@shar0119
Copy link

shar0119 commented Feb 9, 2018

Would it be possible to create a .NETCore 2.0 build?

@shar0119
Copy link
Author

shar0119 commented Feb 9, 2018

I was able to build it for .NET Core 2.0 but I had to make the following two changes and will try to test the areas that this affects. If you have any feedback about these two changes, that would be great to receive.

private static readonly SecureRandom _secureRandom = new SecureRandom(new CryptoApiRandomGenerator());

to

private static readonly SecureRandom _secureRandom = new SecureRandom(new VmpcRandomGenerator());

AND

selectedBytes = SubjectPublicKeyInfoFactory.CreateSubjectPublicKeyInfo(DotNetUtilities.FromX509Certificate(certificate).GetPublicKey()).GetDerEncoded();

to

selectedBytes = SubjectPublicKeyInfoFactory.CreateSubjectPublicKeyInfo(PublicKeyFactory.CreateKey(certificate.GetPublicKey())).GetDerEncoded();

@ststeiger
Copy link

ststeiger commented Feb 21, 2018

You could have spared you the work.
I ported it a long time ago, to .NET Core 1.Whatever
If you had googled it, you would have found it here:
https://github.com/ststeiger/Arsoft

@shar0119
Copy link
Author

shar0119 commented Mar 7, 2018

Thank you, that helps out a lot!

@shar0119 shar0119 closed this as completed Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants