Skip to content
This repository has been archived by the owner on Jan 11, 2021. It is now read-only.

Code duplication in Notifier #33

Closed
auricgoldfinger opened this issue Sep 8, 2016 · 1 comment
Closed

Code duplication in Notifier #33

auricgoldfinger opened this issue Sep 8, 2016 · 1 comment

Comments

@auricgoldfinger
Copy link
Contributor

To provide a good and future-proof fallback for Event labels in notifications, I duplicated the getLabelFor() code from ContactEventView.

This duplication must be refactored so that the same code can be used in ContactEventView as well as in Notifier.

@alexstyl
Copy link
Owner

alexstyl commented Sep 8, 2016

Fixed in #35

@alexstyl alexstyl closed this as completed Sep 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants