You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Yah, we originally did but it wasn't backward compatible with old versions of sass that people might be using. :( This applies specifically to folks using asset pipeline.
We plan on using Sass Maps soon when we no longer have to worry about backwards compatibility. Sass maps are much easier to read and use IMO.
@hugogiraudel we'd prefer to use maps for $ubtn-sizes$ubtn-colors and $ubtn-shapes and hope to do so in time. The company I work for is stuck on a pre 4.0 version of Rails and can't upgade yet (or get off pipeline anytime soon), so that's where I discovered the need for backwards compatibility here. Yup, it's a bit of a shame, but hopefully we'll be able to use the much easier maps not too far out.
Thanks again for lending a set of eyes to the codebase!
Any reason you don't use Sass maps here: https://github.com/alexwolfe/Buttons/blob/master/scss/_options.scss#L46?
The text was updated successfully, but these errors were encountered: