Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass maps instead of lists #49

Closed
KittyGiraudel opened this issue Dec 2, 2014 · 2 comments
Closed

Sass maps instead of lists #49

KittyGiraudel opened this issue Dec 2, 2014 · 2 comments

Comments

@KittyGiraudel
Copy link

Any reason you don't use Sass maps here: https://github.com/alexwolfe/Buttons/blob/master/scss/_options.scss#L46?

@alexwolfe
Copy link
Owner

Yah, we originally did but it wasn't backward compatible with old versions of sass that people might be using. :( This applies specifically to folks using asset pipeline.

We plan on using Sass Maps soon when we no longer have to worry about backwards compatibility. Sass maps are much easier to read and use IMO.

@roblevintennis
Copy link
Collaborator

@hugogiraudel we'd prefer to use maps for $ubtn-sizes $ubtn-colors and $ubtn-shapes and hope to do so in time. The company I work for is stuck on a pre 4.0 version of Rails and can't upgade yet (or get off pipeline anytime soon), so that's where I discovered the need for backwards compatibility here. Yup, it's a bit of a shame, but hopefully we'll be able to use the much easier maps not too far out.

Thanks again for lending a set of eyes to the codebase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants