Feature/test write box #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! 👍 |
alfg
reviewed
Jul 29, 2020
| @@ -20,3 +20,4 @@ license = "MIT" | |||
| [dependencies] | |||
| thiserror = "^1.0" | |||
| byteorder = "1" | |||
| num-rational = "0.3" | |||
There was a problem hiding this comment.
Just missed this. But this means Cargo.lock needs an update too, right?
There was a problem hiding this comment.
Yes, I missed it.
But, I am not sure if it is OK to keep Cargo.lock.
https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries
There was a problem hiding this comment.
Ah, I wasn't aware it wasn't recommended for libraries. I've removed the Cargo.lock and added it to .gitignore. Thanks for the clarification.
jprochazk
pushed a commit
to jprochazk/mp4
that referenced
this pull request
Sep 18, 2024
* Add ReadBox trait * Add boxtype macro * Remove offset in BoxHeader * Fix parsing error when box has largesize * Remove duplicated codes reading version and flags * Add test code for all leaves in box tree * Remove entry_count that is duplacated with entries.len() * Change volume type to Ratio<u16> Co-authored-by: Byungwan Jun <unipro.kr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entries.len()