Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In "alfresco/renderers/Indicators" is not included "alfresco/renderers/Property" #1376

Closed
troncador opened this issue May 9, 2017 · 1 comment

Comments

@troncador
Copy link

In "alfresco/renderers/Indicators" the function use getRenderedProperty and it doesn't exist in 'this'.

  postMixInProperties: function alfresco_renderers_Indicators__postMixInProperties() {
    var property = this.currentItem && this.propertyToRender && this.currentItem.node.properties[this.propertyToRender];
     // this.getRenderedProperty doesn't exist !!
     this.renderedValue = (property && this.getRenderedProperty(property)) || ""; 
     this._currentIndicators = this.normaliseIndicators(this.currentItem);
 },

I think "alfresco/renderers/Property" should be included in the dependencies

@draperd
Copy link

draperd commented May 9, 2017

I think that you're correct here. However, the current situation is that Aikau has been de-prioritized and as such we are not making any more releases other than to hotfix customer raised issues on features included in Alfresco Share. It's interesting that the unit tests didn't pick up on this failure so the widget must be functional to some extent. If however, this issue is directly impacting you then it can easily be resolved by extending the alfresco/renderers/Indicators widget and simply adding in the additional dependency, e.g.

define(["dojo/_base/declare", 
        "aikau/renderers/Indicators",
        "alfresco/renderers/Property"], 
        function(declare, Indicators, Property) {

   return declare([Indicators, Property], {})
})

Therefore at the present time this issue will not be fixed.

@draperd draperd closed this as completed May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants