Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Id names in inspect tab does not consistently save them to XML file. #58

Closed
xkilian opened this issue Oct 17, 2019 · 10 comments
Closed

Comments

@xkilian
Copy link
Contributor

xkilian commented Oct 17, 2019

Editing in the inspect tab will often work and changes are applied to the XML. Unfortunately, changes done to the inspect tab often are not actually applied to the XML definition. So when saving and reopening the dashboard, changes are lost.
Manually editing the XML works for testing purposes. Using Firefox 69 and Grafana 6.0.2.
Keep up the great work!

@algenty
Copy link
Owner

algenty commented Oct 18, 2019

Hi xkilian,
I'll try it

@xkilian
Copy link
Contributor Author

xkilian commented Oct 18, 2019

Using the latest snapshort it works with a quick test. But will go through a full creation from scratch to make sure I catch it if it does come up. (And what I did prior to the issue cropping up. Because in the original testing I used two different firefox version and I was swapping between inspect and rule creation. So the exact steps to reproduce are a little hazy.

@algenty
Copy link
Owner

algenty commented Dec 9, 2019

Hi @xkilian
Can you try the lastest version in download section ?

@tbaczynski
Copy link

I'm not sure this is exactly this same problem, it was, but in the meantime i upgraded grafana and plugin, and now I have situation, when i do not see 'apply changes' button on Graph Inspect ID. I cannot see any posibility to manage/save new names for objects.
grafana (6.5.2) and plugin (0.6.0).
image

@NURULFARAHINirwanshah
Copy link

I'm not sure this is exactly this same problem, it was, but in the meantime i upgraded grafana and plugin, and now I have situation, when i do not see 'apply changes' button on Graph Inspect ID. I cannot see any posibility to manage/save new names for objects.
grafana (6.5.2) and plugin (0.6.0).
image

Hi, I'm having the same problem here. Have you found the solution?

Regards,
Farah

@jorlandobr
Copy link

jorlandobr commented Jan 22, 2020

I'm not sure this is exactly this same problem, it was, but in the meantime i upgraded grafana and plugin, and now I have situation, when i do not see 'apply changes' button on Graph Inspect ID. I cannot see any posibility to manage/save new names for objects.
grafana (6.5.2) and plugin (0.6.0).
image

Experiencing the same problem. There is no "Apply Changes" button.

Grafana v6.4.4(092e514), Flowcharting v0.6.0

Tried editing in Chrome 79.0.3945.117 (64-bits) and Firefox 72.0.2 (64-bits)

@jorlandobr
Copy link

jorlandobr commented Jan 24, 2020

I removed version 0.6 and manually installed 0.50. The "Apply Changes" button appears after renaming some id.

@algenty
Copy link
Owner

algenty commented Jan 24, 2020

Fixed in 0.6.1.
Release in progress
grafana/grafana-plugin-repository#556
Put a health to speed it up ;)

@algenty
Copy link
Owner

algenty commented Jan 24, 2020

agenty-flowcharting-panel-0.6.1-SNAPSHOT.zip
The preview

@jorlandobr
Copy link

jorlandobr commented Jan 24, 2020

Just tested!

"Apply Changes" button appears after renaming ids.

Saved changes, opened another browser in a different computer and could confirm that the changes were made and saved! :-)

@algenty algenty closed this as completed Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants