Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTP Proxies #39

Closed
davidiw opened this issue Feb 6, 2020 · 4 comments
Closed

Support HTTP Proxies #39

davidiw opened this issue Feb 6, 2020 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@davidiw
Copy link
Contributor

davidiw commented Feb 6, 2020

Many thanks for your endeavors. We have actually included ureq into our trusted computing base of Libra. I would prefer we standardize its usage across our code base, but there are concerns that it does not currently support HTTP Proxies. Is this something you could consider? And if not, worst-case scenario, accept a 3rd party contribution?

@algesten
Copy link
Owner

algesten commented Feb 6, 2020

Hi @davidiw! Thank you and exciting to see it used. Regarding new features, I'll reiterate what I said in #37

I'm going to clarify the future of ureq by updating the README soon. But in a nutshell.

I'll keep maintaining ureq as is cause there seems to be interest in a blocking simple http client. With maintaining I mean keep dependencies somewhat fresh and address any bad bugs. I will however not personally implement new features in ureq, but I do welcome PR with open arms.

The code base is extremely simple, one might even call naive. It's a good project to hack on as first learning experience in Rust. I will uphold some base line of code hygiene, but won't block a PR due to something being a bit inelegant.

@algesten algesten added enhancement New feature or request help wanted Extra attention is needed labels Feb 6, 2020
@rustysec
Copy link
Contributor

Should we close this with #42?

@lolgesten
Copy link
Contributor

@rustysec yeah lets. there are obviously more proxy types out there, but they can be separate issues/PR as the need arises.

@rustysec
Copy link
Contributor

Go for it 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants