fix(node): allow passing requesterOptions #1215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the crawler we are trying to control more our http connections
and we would like to modify the behavior of the client to test a few things, especially the
family
options.This option is related to ip resolution and a "fix" to reduse some network errors like:
ENOTFOUND
EAI_AGAIN
Those errors are the most common ones that triggers the infamous "Unreachable hosts"
ref: nodejs/node#5436 (comment)
(personal opinion would be to use
family: 4
by default, DM for more about this)If you are not confident letting people modify the whole options, we'll be fine with just the
family
option.