-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spell success properly #1254
Spell success properly #1254
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 07dcc12:
|
hi @greg0ire, thanks a lot for this PR, but as you guessed it, this would be a breaking change for those who write a custom requester today. It would be possible to alias it to the correct name, and accept both wrong and correct spelling, or to add a comment |
Is there a standard way in JS to trigger a deprecation when a call is performed with the wrong spelling? |
No, there's no standard way of that, it would be calling the previous function and adding a log. At the moment for the sake of avoiding a major change for just this, I'd be edging on the side of having just a comment for now |
2df16ea
to
07dcc12
Compare
Warning: I'm not a JS developer so I have no idea if there might be BC-breaks in this PR or not. I also don't know if this might actually fix any bug, hence why I picked
refactor
here.