Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): allow mixed arrays in numeric and tag filters #1395

Merged
merged 1 commit into from
Feb 24, 2022
Merged

fix(types): allow mixed arrays in numeric and tag filters #1395

merged 1 commit into from
Feb 24, 2022

Conversation

eliasnorrby
Copy link

Correct me if I'm wrong, but I believe the fix for facetFilters in #1384 should apply to numericFilters and tagFilters as well.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1cf9d39:

Sandbox Source
algolia/create-instantsearch-app Configuration

Haroenv
Haroenv approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, that's correct!

@Haroenv Haroenv merged commit 326c833 into algolia:master Feb 24, 2022
@eliasnorrby
Copy link
Author

@Haroenv As with #1384, given that this repo does not have automatic releases, would you be able to trigger one manually? 😇

@shortcuts
Copy link
Member

Hey @eliasnorrby, it will be released once #1397 is merged

@shortcuts shortcuts mentioned this pull request Jul 1, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eliasnorrby @shortcuts @Haroenv