-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(neuralsearch): add mode to settings types #1439
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2cb3525:
|
Is this the final wording? I saw |
These are the discussion points for the naming. The settled value is edit: {
"searchableAttributes": [
"title",
"description",
"brand"
],
"semanticSearch": {
[...]
},
"mode": "neuralSearch",
"customRanking": [
"desc(retweets)",
"desc(likes)"
]
}
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me 🆗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but I don't feel comfortable approving/releasing this when naming can still change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
@Haroenv are you okay if I merge? Is this automatically released or is it manual? |
I'd wait for @shortcuts, I don't think I have credentials to release anymore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all goood thanks!!
Motivation
setSettings
call.