Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.20.0 upgrade prevents project from building #854

Closed
squarefrog opened this issue Feb 2, 2024 · 4 comments
Closed

8.20.0 upgrade prevents project from building #854

squarefrog opened this issue Feb 2, 2024 · 4 comments

Comments

@squarefrog
Copy link

Describe the bug πŸ›
We use the instantsearch-ios 7.26.1 package in our app. About an hour ago we noticed our CI pipelines were failing with the following output:

❌  error: The package product 'AlgoliaSearchClient' requires minimum platform version 14.0 for the iOS platform, but this target supports 12.0 (in target 'InstantSearchCore' from project 'InstantSearch')
❌  error: The package product 'AlgoliaSearchClient' requires minimum platform version 14.0 for the iOS platform, but this target supports 12.0 (in target 'InstantSearch' from project 'InstantSearch')
❌  error: The package product 'AlgoliaSearchClient' requires minimum platform version 14.0 for the iOS platform, but this target supports 12.0 (in target 'InstantSearchInsights' from project 'InstantSearch')

After some digging, I can see instant search package references this package using the from rule, so it was naturally updated.

Our project has a minimum deployment target of iOS 15, so there should be no reason this change is a breaking one.

To Reproduce πŸ”
Steps to reproduce the behavior:

  1. Create a new Xcode project in Xcode 15, targeting iOS
  2. Set the minimum deployment target to iOS 15
  3. Add https://github.com/algolia/instantsearch-ios as a package dependency, with the rule set to exact and the version 7.26.1
  4. Add all frameworks
  5. Build

Expected behavior πŸ’­
Package should build without failure for products targeting iOS 14 or above.

Screenshots πŸ–₯

Screenshot 2024-02-02 at 15 20 13

Environment:

  • OS: iOS
  • Version: 15.0
  • Swift Package Manager
  • Xcode 15.2

Additional context
Manually adding algoliasearch-client-swift with a locked version of 8.19.0 allows the project to build again, as this overrides the from rule locally

@squarefrog
Copy link
Author

Actually, I think this is an issue with instantsearch-ios as the minimum target for that package is iOS 9. I would however argue bumping the minimum version is probably a major release rather than minor following semver rules.

@VladislavFitz
Copy link

Replied here

@squarefrog
Copy link
Author

I’ll close this as a duplicate on the parent package.

@Ma7m0udalaa
Copy link

Any update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants