fix(button): prevent container keys ui flash #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bfa436a:
|
shortcuts
force-pushed
the
fix/key-container-ui-flash
branch
from
5389a64
to
751d400
Compare
Co-authored-by: François Chalifour <francoischalifour@users.noreply.github.com>
francoischalifour
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1021
Summary
This PR prevent the UI flash for server-side rendered websites. Since the
keyvalue isnull, thekeyscontainer isn't rendered and therefore causes a UI flash.Result
The condition is now a level below (on the
keys), and we've added a fixedwidthto the container.Preview
Screen.Recording.2021-07-23.at.15.47.59.mov
Related