Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade Docsearch to avoid layout shift #5214

Merged
merged 2 commits into from
Jul 24, 2021
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 23, 2021

Motivation

Should fix layout shift on hydration.

algolia/docsearch#1021
algolia/docsearch#1033

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

preview => https://deploy-preview-5214--docusaurus-2.netlify.app/

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jul 23, 2021
@slorber slorber requested a review from lex111 as a code owner July 23, 2021 12:25
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 23, 2021
@netlify
Copy link

netlify bot commented Jul 23, 2021

✔️ [V2]

🔨 Explore the source changes: d18a81e

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60fc404d40399a0007142558

😎 Browse the preview: https://deploy-preview-5214--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jul 23, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 93
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5214--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Jul 23, 2021

Size Change: +3.2 kB (0%)

Total Size: 856 kB

Filename Size Change
website/build/assets/css/styles.********.css 92 kB +2.96 kB (+3%)
website/build/assets/js/main.********.js 461 kB -30 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.4 kB +43 B (0%)
website/build/blog/index.html 26.4 kB +43 B (0%)
website/build/docs/index.html 40.3 kB +43 B (0%)
website/build/index.html 27.3 kB +43 B (0%)
website/build/tests/docs/index.html 20.9 kB +43 B (0%)
website/build/tests/docs/standalone/index.html 18.8 kB +43 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 59.2 kB 0 B
website/build/docs/installation/index.html 47.9 kB +19 B (0%)

compressed-size-action

@slorber slorber merged commit 8621ae2 into master Jul 24, 2021
@slorber slorber deleted the slorber/algolia-alpha.38 branch August 17, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants