Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When only one result is returned, priceRanges widget displays bad values instead of none #1536

Closed
JanPetr opened this issue Nov 10, 2016 · 0 comments · Fixed by #1544
Closed

When only one result is returned, priceRanges widget displays bad values instead of none #1536

JanPetr opened this issue Nov 10, 2016 · 0 comments · Fixed by #1544
Assignees
@vvo
Labels
Type: Bug

Comments

@JanPetr
Copy link
Contributor

JanPetr commented Nov 10, 2016 •
edited
Loading

Do you want to request a feature or report a bug?
bug

What is the current behavior?
When only one result is returned from Algolia the price ranges widget displays:
pasted_image_at_2016_11_10_02_15_pm

If the current behavior is a bug, please provide all the steps to reproduce and if possible a minimal JSFiddle example or a repository on GitHub that we can npm install and npm start.
https://jsfiddle.net/JanPetr/w6vwmer9/1/ - When you search for "a" it keeps the price ranges displayed. When you search for "s", it hides the widget.
There seems to be issue with higher numbers as when "Apple" had price 80, everything worked.

What is the expected behavior?
Completely hidden priceRanges widget
@JanPetr JanPetr closed this as completed Nov 10, 2016
@JanPetr JanPetr reopened this Nov 11, 2016
@vvo vvo added the Type: Bug label Nov 14, 2016
@vvo vvo self-assigned this Nov 14, 2016
vvo pushed a commit that referenced this issue Nov 14, 2016
fix(priceRanges): avoid displaying solo ranges
5275659 
fixes #1536
@vvo vvo mentioned this issue Nov 14, 2016
Merged
bobylito pushed a commit that referenced this issue Nov 14, 2016
@vvo @bobylito
fix(priceRanges): avoid displaying solo ranges (#1544)
ff396f0 
fixes #1536
vvo pushed a commit that referenced this issue Nov 16, 2016
v1.8.15
18940f0 
<a name="1.8.15"></a>
## [1.8.15](v1.8.14...v1.8.15) (2016-11-16)

### Bug Fixes

* **priceRanges:** avoid displaying solo ranges (#1544) ([ff396f0](ff396f0)), closes [#1536](#1536)
* **priceRanges:** use formatNumber in defaultTemplate (#1559) ([557a501](557a501)), closes [#1230](#1230)
* **toggle:** support negative numeric values for on/off (#1551) ([e4d88e0](e4d88e0)), closes [#1537](#1537)
* **transformData:** always call transformData (#1555) ([49bfeca](49bfeca)), closes [#1538](#1538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vvo vvo

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(priceRanges): avoid displaying solo ranges algolia/instantsearch
2 participants
@vvo @JanPetr