Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(priceRanges): avoid displaying solo ranges #1544

Merged
merged 1 commit into from
Nov 14, 2016
Merged

fix(priceRanges): avoid displaying solo ranges #1544

merged 1 commit into from
Nov 14, 2016

Conversation

vvo
Copy link
Contributor

@vvo vvo commented Nov 14, 2016

fixes #1536

@algobot
Copy link
Contributor

algobot commented Nov 14, 2016

By analyzing the blame information on this pull request, we identified @redox, @maxiloc and @jerskouille to be potential reviewers

bobylito
bobylito approved these changes Nov 14, 2016
View reviewed changes
Copy link
Contributor

@bobylito bobylito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and efficient! 👍

@bobylito bobylito merged commit ff396f0 into develop Nov 14, 2016
@JanPetr
Copy link
Contributor

JanPetr commented Nov 14, 2016

🎉

@vvo vvo deleted the fix/priceRanges-no-ranges branch November 14, 2016 20:12
vvo pushed a commit that referenced this pull request Nov 16, 2016
v1.8.15
18940f0 
<a name="1.8.15"></a>
## [1.8.15](v1.8.14...v1.8.15) (2016-11-16)

### Bug Fixes

* **priceRanges:** avoid displaying solo ranges (#1544) ([ff396f0](ff396f0)), closes [#1536](#1536)
* **priceRanges:** use formatNumber in defaultTemplate (#1559) ([557a501](557a501)), closes [#1230](#1230)
* **toggle:** support negative numeric values for on/off (#1551) ([e4d88e0](e4d88e0)), closes [#1537](#1537)
* **transformData:** always call transformData (#1555) ([49bfeca](49bfeca)), closes [#1538](#1538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobylito bobylito bobylito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When only one result is returned, priceRanges widget displays bad values instead of none
4 participants
@vvo @algobot @JanPetr @bobylito