Bug: Hit not re-rendered when you modify the data in transformData #1538
Assignees
Labels
Comments
|
We have found a solution for that: we would need to actually call transformData BEFORE it's passed to the Template component: makes sense, you want to do a shouldComponentUpdate on data that is fully computed. |
vvo
pushed a commit
that referenced
this issue
Nov 15, 2016
Event when data does not changes, we now call transformData, so that if the transformedData changes, there will be a new render. fixes #1538
vvo
added a commit
that referenced
this issue
Nov 16, 2016
Event when data does not changes, we now call transformData, so that if the transformedData changes, there will be a new render. fixes #1538
vvo
pushed a commit
that referenced
this issue
Nov 16, 2016
<a name="1.8.15"></a> ## [1.8.15](v1.8.14...v1.8.15) (2016-11-16) ### Bug Fixes * **priceRanges:** avoid displaying solo ranges (#1544) ([ff396f0](ff396f0)), closes [#1536](#1536) * **priceRanges:** use formatNumber in defaultTemplate (#1559) ([557a501](557a501)), closes [#1230](#1230) * **toggle:** support negative numeric values for on/off (#1551) ([e4d88e0](e4d88e0)), closes [#1537](#1537) * **transformData:** always call transformData (#1555) ([49bfeca](49bfeca)), closes [#1538](#1538)
vvo
added a commit
that referenced
this issue
Nov 16, 2016
Event when data does not changes, we now call transformData, so that if the transformedData changes, there will be a new render. fixes #1538
bobylito
pushed a commit
that referenced
this issue
Nov 17, 2016
* fix(transformData): always call transformData (#1555) Event when data does not changes, we now call transformData, so that if the transformedData changes, there will be a new render. fixes #1538 * fix(transformData): default data is an object when not provided This fixes the nasty regression bug we have seen and reimplement the transformData fix
vvo
pushed a commit
that referenced
this issue
Dec 14, 2016
<a name="1.9.0"></a> # [1.9.0](v1.8.16...v1.9.0) (2016-12-14) ### Bug Fixes * **currentRefinedValues:** unescape disjunctive facet refinement names (#1574) ([9ab65c4](9ab65c4)), closes [#1569](#1569) * **transformData:** default data is an object when not provided (#1570) ([8eeeeba](8eeeeba)), closes [#1538](#1538) ### Features * **analytics:** new analytics widget to easily plug search to any analytics service ([09d8fda](09d8fda)) * **retry strategy:** new retry strategy ([afdcc3c](afdcc3c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When making two queries that return the same hit, but this hit is handled differently in transformData between the first and second query, the hit component won't be re-rendered.
Apparently, that comes from the fact that
shouldComponentUpdateis based on the data retrieved by the API instead of the data sent aftertransformData.An easy way to reproduce this is to add a timestamp to the hit object in
transformData, and display it in the component.The text was updated successfully, but these errors were encountered: