test(menu-select): common test suite #5874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymeric-giraudet
requested review from
a team,
dhayab and
sarahdayan
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6e1d785:
|
aymeric-giraudet
force-pushed
the
test/common-menu-select-tests
branch
from
5f288da
to
7b29ece
Compare
dhayab
reviewed
Jun 6, 2024
There was a problem hiding this comment.
Can you add a test for cssClasses?
There was a problem hiding this comment.
Can't find other CTS that tests this, when I change it it doesn't seem to be taken into account for vue
There was a problem hiding this comment.
Not in CTS, in the JS widget tests. You can look at hits or current refinements for example. We should have done it for all CTS migrated widgets but it seems we forgot a few on the way when I searched for adds custom CSS classes 😅 .
Haroenv
approved these changes
Jun 10, 2024
dhayab
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There weren't many logic tests to remove, probably because they're normally tested in the connector (so
connectMenu)Also obviously had to skip testing for React as it doesn't have
MenuSelect