Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding issues #17

Closed
Haroenv opened this issue Jan 29, 2017 · 8 comments
Closed

encoding issues #17

Haroenv opened this issue Jan 29, 2017 · 8 comments
Labels

Comments

@Haroenv
Copy link
Collaborator

Haroenv commented Jan 29, 2017

At some point the description is parsed as something else than utf-8.

this will make emoji show up as something other than their actual code.

example of that error happening at floating.js

@vvo
Copy link
Contributor

vvo commented Jan 30, 2017

Indeed inside the data it's already badly encoded, so it's an issue in the current indexer

@vvo vvo added the bug label Jan 30, 2017
@Haroenv
Copy link
Collaborator Author

Haroenv commented Feb 6, 2017

A description that has html escape codes like > will also show them escaped once too much (e.g. emoji-images)

@vvo
Copy link
Contributor

vvo commented Feb 6, 2017

I think this is necessary, npm is not doing it but I don't think that's right:

image

(from https://www.npmjs.com/package/emoji-images)

@Haroenv
Copy link
Collaborator Author

Haroenv commented Feb 6, 2017

Yep saw that npm is quite wrong on that, but wouldn't a better solution be one that showed it as <img>?

@vvo
Copy link
Contributor

vvo commented Feb 6, 2017

That would be nicer yes, we have seen packages with weird content in it that would display it better this way yes, like yarn:

image

@vvo
Copy link
Contributor

vvo commented Feb 6, 2017

I don't know if those two things have the same root cause, I would say it's different, one is bad encoding the other is "bad" escaping (dumb one)

@Haroenv
Copy link
Collaborator Author

Haroenv commented Feb 6, 2017

Issue is happening because backend strings are being ported to UCS-2, but then when highlighted being parsed into utf8 again, which causes problem with multi-byte characters (like emoji) cc @redox

@Haroenv
Copy link
Collaborator Author

Haroenv commented Mar 3, 2017

close in favour of internal issue

@Haroenv Haroenv closed this as completed Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants