feat(vue 3): support vue 3 #990

eunjae-lee · 2021-06-01T13:06:11Z

Summary

This is a base branch for all the Vue 3 related PRs.

How to try this branch

scroll to bottom
click the status icon of the latest commit
click "Details" on "ci/codesandbox" item
get the url to install the temporary version from this branch
import like this:

import InstantSearch from 'vue-instantsearch/vue3/es'

let us know how it goes and if you see any bug

CleanShot.2021-07-02.at.09.59.52.mp4

Major TODOs

vue-router@4: It just works, only with one change on the userland: vueRouter.currentRoute.query → vueRouter.currentRoute.value.query (need update the doc and the example)
Vue 3 with vue-cli
Vue 3 with vite
Vue 3 SSR with vue-cli
Vue 3 SSR with vite
Nuxt 3 (when it becomes public beta, which isn't yet)

Co-authored-by: eunjae-lee <karis612@gmail.com>

@input

v-model used to be @input / :value, but is now @update:modelValue / :modelValue. Since those don't overlap, it's possible to support both, by using them as fallback "emits" is now also required in v3, so I added this to all components emitting docs: https://v3.vuejs.org/guide/migration/v-model.html

Co-authored-by: eunjae-lee <karis612@gmail.com>

* feat(vue 3): support both defineComponent and component * chore: clean up with vue-demi

codesandbox-ci · 2021-06-01T13:14:33Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dcdf81c:

Sandbox	Source
vue-instantsearch-e-commerce	Configuration

Kocal · 2021-06-01T13:34:25Z

Nice job @eunjae-lee! ✨ ❤️

This reverts commit cf7f20a, because the issue has been fixed since Vue@3.1.2 by vuejs/core#3925

Co-authored-by: Haroen Viaene <hello@haroen.me>

* fix(vue 3): replace slot-scope with v-slot * fix(StateResults): update the default message

…jest (#1027)

…1028)

Co-authored-by: eunjae-lee <karis612@gmail.com> Co-authored-by: Eunjae Lee <eunjae.lee@algolia.com>

Co-authored-by: khou <jean-michel.khou@vivlab.fr>

…1035)

…nput` (#1036)

Haroenv · 2021-08-17T12:41:44Z

let's make sure we rebase instead of squashing this PR to preserve the history and changelog

* chore(v3 compat): shorten import path for vue3 * chore: change bundle output directory for vue 2 * chore: add dist/ back to .gitignore * chore: add dist/ back to .eslintignore * reorden gitignore * Update package.json Co-authored-by: Haroen Viaene <hello@haroen.me> Co-authored-by: Haroen Viaene <hello@haroen.me>

* chore: release v4.0.0-beta.2 * Update CHANGELOG.md Co-authored-by: eunjae-lee <karis612@gmail.com> Co-authored-by: Eunjae Lee <eunjae.lee@algolia.com>

…ServerRootMixin (#1044) * fix(vue 3): pass renderToString to findResultsState instead of createServerRootMixin * fix: change findResultsState to accept an object as props

Co-authored-by: eunjae-lee <karis612@gmail.com>

Haroenv · 2021-08-23T12:36:22Z

CHANGELOG.md

@@ -1,3 +1,60 @@
+# [4.0.0-beta.3](https://github.com/algolia/vue-instantsearch/compare/v4.0.0-beta.2...v4.0.0-beta.3) (2021-08-20)


should we change this to just say v4 and have all changes to v3?

Yes, I'm planning to update it in the release PR for 4.0.0.

…feat/vue3-compat feat(vue 3): support vue 3

Haroenv and others added 7 commits June 1, 2021 14:38

feat(vue 3): migrate from Vue.default.version to a fallback (#847)

247260e

Co-authored-by: eunjae-lee <karis612@gmail.com>

feat(vue 3): prevent error by migrating events to mitt (#848)

d79cdde

feat(vue 3): make highlighter compatible (#850)

4a1191f

Co-authored-by: eunjae-lee <karis612@gmail.com>

feat(vue 3): make render function of JS files compatible (#855)

48f24c3

Co-authored-by: eunjae-lee <karis612@gmail.com>

feat(vue 3): support both defineComponent and component (#948)

3e9db5e

* feat(vue 3): support both defineComponent and component * chore: clean up with vue-demi

feat(vue 3): support inject without this (#951)

cf7f20a

eunjae-lee added this to the Vue 3 milestone Jun 1, 2021

Eunjae Lee and others added 2 commits June 1, 2021 15:06

Merge branch 'master' into feat/vue3-compat

aed9418

fix: fix wrong imports from vue-demi

65b1b7b

Eunjae Lee and others added 7 commits June 10, 2021 10:48

feat(vue 3): update rollup-plugin-vue (#952)

b931ac0

feat(vue 3): rename beforeDestroy to beforeUnmount (#998)

626567a

chore: update yarn.lock

2cf8e96

chore(vue 3): update external at rollup config (#999)

f51c2b3

fix(vue 3): fix unit tests for panel (#1000)

ca728b8

fix(vue 3): fix Panel (#1002)

48228cb

chore: switch back to vue 2 after building

9503d54

Haroenv mentioned this pull request Jun 17, 2021

Vue3 is not supported #890

Closed

eunjae-lee and others added 10 commits June 24, 2021 11:19

fix: Revert "feat(vue 3): support inject without this (#951)"

5d87a85

This reverts commit cf7f20a, because the issue has been fixed since Vue@3.1.2 by vuejs/core#3925

chore(vue 3): enable unit tests for Vue 3 (#1003)

be222d7

Co-authored-by: Haroen Viaene <hello@haroen.me>

fix(vue 3): update @vue/test-utils for vue2 and fix test cases (#1006)

f2e4359

test(vue 3): replace slot-scope with v-slot (#1008)

6d96224

* fix(vue 3): replace slot-scope with v-slot * fix(StateResults): update the default message

chore: remove vue-demi (#1009)

59adac3

Merge branch 'master' into feat/vue3-compat

d3c3177

test: update tests compatible for both vue 2 and vue 3 [1/2] (#1014)

7d36442

fix(vue 3): update the implementation of createServerRootMixin (#1020)

684ba11

test: update tests compatible for both vue 2 and vue 3 [2/2] (#1021)

30487a2

refactor(vue 3): add utils for compatibility (#1022)

67a2d55

Eunjae Lee and others added 12 commits July 22, 2021 10:32

chore(vue 3): extract commands as a file to run tests with vue 3 (#1023)

41d32c9

chore(examples): add examples for Vue 3 SSR (#1026)

72475f5

fix(vue 3): fixes createServerRootMixin (#1024)

837055d

fix(vue 3): fix renderToString for vue 2 and update babel config for …

bda15b0

…jest (#1027)

fix(vue 3): update @vue/test-utils and use setData for array items (#…

686a9a7

…1028)

fix(vue 3): do not pass props for cloned component in vue 3 (#1029)

d76c308

chore(vue 3): enable shipjs (#1030)

c5c45b0

chore: release v4.0.0-beta.0 (#1031)

06a6b6f

Co-authored-by: eunjae-lee <karis612@gmail.com> Co-authored-by: Eunjae Lee <eunjae.lee@algolia.com>

chore: release v4.0.0-beta.1 (#1032)

ef9cc81

Co-authored-by: eunjae-lee <karis612@gmail.com> Co-authored-by: Eunjae Lee <eunjae.lee@algolia.com>

docs(example): pass correct items from render in vue 3 ssr (#1033)

93343df

Co-authored-by: khou <jean-michel.khou@vivlab.fr>

fix(vue 3): let users pass renderToString to createServerRootMixin (#…

bc5f58a

…1035)

fix(range-input): remove default min and max values from `ais-range-i…

38987ac

…nput` (#1036)

eunjae-lee marked this pull request as ready for review August 17, 2021 12:55

Eunjae Lee and others added 7 commits August 19, 2021 11:08

chore(deps): update instantsearch.js to 4.27.2 (#1039)

e89ce49

chore: release v4.0.0-beta.2 (#1043)

0075736

* chore: release v4.0.0-beta.2 * Update CHANGELOG.md Co-authored-by: eunjae-lee <karis612@gmail.com> Co-authored-by: Eunjae Lee <eunjae.lee@algolia.com>

chore: remove examples (#1042)

58675f0

fix(vue 3): pass renderToString to findResultsState instead of create…

43aed4f

…ServerRootMixin (#1044) * fix(vue 3): pass renderToString to findResultsState instead of createServerRootMixin * fix: change findResultsState to accept an object as props

chore: release v4.0.0-beta.3 (#1045)

5b1ff3f

Co-authored-by: eunjae-lee <karis612@gmail.com>

chore(examples): update nuxt and ssr examples regarding renderToString

dcdf81c

eunjae-lee requested a review from Haroenv August 23, 2021 12:29

Haroenv reviewed Aug 23, 2021

View reviewed changes

Haroenv approved these changes Aug 23, 2021

View reviewed changes

eunjae-lee merged commit f02a173 into master Aug 23, 2021

eunjae-lee deleted the feat/vue3-compat branch August 23, 2021 12:54

Haroenv pushed a commit to algolia/instantsearch that referenced this pull request Dec 28, 2022

chore: merge pull request algolia/vue-instantsearch#990 from algolia/…

d43642f

…feat/vue3-compat feat(vue 3): support vue 3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(vue 3): support vue 3 #990

feat(vue 3): support vue 3 #990

eunjae-lee commented Jun 1, 2021 •

edited

Loading

codesandbox-ci bot commented Jun 1, 2021 •

edited

Loading

Kocal commented Jun 1, 2021

Haroenv commented Aug 17, 2021 •

edited

Loading

Haroenv Aug 23, 2021

eunjae-lee Aug 23, 2021 •

edited

Loading

		@@ -1,3 +1,60 @@
		# [4.0.0-beta.3](https://github.com/algolia/vue-instantsearch/compare/v4.0.0-beta.2...v4.0.0-beta.3) (2021-08-20)

feat(vue 3): support vue 3 #990

feat(vue 3): support vue 3 #990

Conversation

eunjae-lee commented Jun 1, 2021 • edited Loading

Summary

How to try this branch

Major TODOs

codesandbox-ci bot commented Jun 1, 2021 • edited Loading

Kocal commented Jun 1, 2021

Haroenv commented Aug 17, 2021 • edited Loading

Haroenv Aug 23, 2021

Choose a reason for hiding this comment

eunjae-lee Aug 23, 2021 • edited Loading

Choose a reason for hiding this comment

eunjae-lee commented Jun 1, 2021 •

edited

Loading

codesandbox-ci bot commented Jun 1, 2021 •

edited

Loading

Haroenv commented Aug 17, 2021 •

edited

Loading

eunjae-lee Aug 23, 2021 •

edited

Loading