Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for travis ARM64 integration tests #335

Merged
merged 9 commits into from Sep 19, 2019

Conversation

tsachiherman
Copy link
Contributor

@tsachiherman tsachiherman commented Sep 18, 2019

Summary

This PR adds the following functionality:

  1. Add ARM64 integration testing support for travis PRs and releases.
  2. Improve ARM64 builds performance by avoid installing unneeded components on travis machine.
  3. Improve error handling of buildhost on arm64 builds.
  4. Pass the following variables from travis to the ephermal build machines:
    TRAVIS_BRANCH
    TRAVIS_COMMIT
    TRAVIS_PULL_REQUEST
  5. Simplify the travis scripts by invoking a integration_test.sh or build_test.sh; The BUILD_TYPE="integration" would be set by these scripts instead of Travis. That allows us to invoke the same functionality from other sources. ( i.e. ephermal build machine )
  6. Replace the usage of TRAVIS_BUILD_NUMBER with TRAVIS_JOB_NUMBER allowing multiple concurrent external builds for the same build.

@tsachiherman tsachiherman changed the title integration test. Add support for travis ARM64 integration tests Sep 19, 2019
@tsachiherman tsachiherman marked this pull request as ready for review September 19, 2019 13:56
Copy link
Contributor

@pzbitskiy pzbitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

env:
- BUILD_TYPE: "external_build"
- TARGET_PLATFORM: "linux-arm64"
addons:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is nice, did not know travis has it

@@ -52,29 +52,31 @@ if [ "${BUILD_TARGET}" = "" ]; then
exit 1
fi

sudo apt-get install awscli
BUILDID=${TRAVIS_JOB_NUMBER/./000}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see a comment example what is in TRAVIS_JOB_NUMBER and what is in BUILDID after replacement (that is not well-known feature)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do in subsequent PR.

@tsachiherman tsachiherman merged commit 187fb96 into algorand:master Sep 19, 2019
@tsachiherman tsachiherman deleted the tsachi/morearm64 branch September 19, 2019 19:07
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

#
# SPDX-License-Identifier: MIT
#
# Based on the travis-ci/travis-build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants