New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for travis ARM64 integration tests #335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
env: | ||
- BUILD_TYPE: "external_build" | ||
- TARGET_PLATFORM: "linux-arm64" | ||
addons: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is nice, did not know travis has it
@@ -52,29 +52,31 @@ if [ "${BUILD_TARGET}" = "" ]; then | |||
exit 1 | |||
fi | |||
|
|||
sudo apt-get install awscli | |||
BUILDID=${TRAVIS_JOB_NUMBER/./000} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see a comment example what is in TRAVIS_JOB_NUMBER and what is in BUILDID after replacement (that is not well-known feature)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do in subsequent PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# | ||
# SPDX-License-Identifier: MIT | ||
# | ||
# Based on the travis-ci/travis-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never knew about this. Never really thought about how the YML is actually executed. A link to the actual source files may be useful for future debugging:
https://github.com/travis-ci/travis-build/blob/d8f183b29700c3b98b6995ecc4b463f3c3bc552f/lib/travis/build/bash/travis_jigger.bash
https://github.com/travis-ci/travis-build/blob/d8f183b29700c3b98b6995ecc4b463f3c3bc552f/lib/travis/build/bash/travis_wait.bash
…#5253) break out client support for body and parameters
Summary
This PR adds the following functionality:
TRAVIS_BRANCH
TRAVIS_COMMIT
TRAVIS_PULL_REQUEST