Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agreement: add counters for dropped tasks and slow responses #3861

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

cce
Copy link
Contributor

@cce cce commented Apr 6, 2022

Summary

In #2741 we added some additional logging for cases where the pseudonode tasks queues (used by MakeVotes and MakeProposals) were full, or if the cryptoVerifier response queue was full, or if it was taking more than 2s to wait for a verifier task to return. This adds counters to accompany those log messages.

Test Plan

Existing tests should pass.

@cce cce requested review from brianolson and a user April 6, 2022 20:59
@cce cce added the Enhancement label Apr 6, 2022
@cce cce self-assigned this Apr 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

Merging #3861 (9977349) into master (0146fff) will increase coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #3861      +/-   ##
==========================================
+ Coverage   49.95%   49.97%   +0.01%     
==========================================
  Files         393      393              
  Lines       68353    68359       +6     
==========================================
+ Hits        34149    34160      +11     
+ Misses      30473    30469       -4     
+ Partials     3731     3730       -1     
Impacted Files Coverage Δ
agreement/cryptoVerifier.go 69.71% <0.00%> (+1.63%) ⬆️
agreement/pseudonode.go 70.07% <40.00%> (-0.56%) ⬇️
catchup/service.go 69.38% <0.00%> (+0.49%) ⬆️
cmd/tealdbg/debugger.go 72.41% <0.00%> (+0.98%) ⬆️
agreement/proposalManager.go 98.03% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0146fff...9977349. Read the comment docs.

@cce cce requested a review from algorandskiy April 7, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants