go-algorand 3.6.2-stable Release PR #3960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary The TestDeadlockLogging was generating large amount of "junk" on top of the expected stack trace. This PR addresses that by dropping the redundant data. Example: https://circleci.com/api/v1.1/project/github/algorand/go-algorand/92568/output/106/0?file=true&allocation-id=622fb105959ff4390b6b098f-0-build%2F5VSI2HBA ## Test Plan Unit test exists.
* Some simple optimizations for app execution Also some benchmarks that show relative costs for the CPU part of processing transactions * Convert opcodes to return error, rather than set cx.err * Pavel recomendation. Considering bigger change to refreshDebugState Tests more opcodes, including branches and others that have not return values. Automates handling of more opcodes by understanding immediate arguments. Fixes the ordering of return value testing. * Unify naming Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> * make sure return types tested even when simple errors occur Co-authored-by: michaeldiamant <michaeldiamant@users.noreply.github.com>
* Warn on invalid method signature assembly * Print warnings to stderr
…count (algorand#3773) ## Summary When trying to sign a transaction file with goal, if the sender is a normal address but the signer is a logic program, the call fails with an error message like: `send.txn: txn[0] error LogicNot signed and not a Logic-only account` The error message comes from https://github.com/algorand/go-algorand/blob/33b87c432065d3be0ce1fdad682604f416676133/data/transactions/verify/txn.go#L314 It notes that a valid case is when Auth is set to the hash of the program but we aren't setting the auth on the transaction even if the -S flag is passed ## Test Plan Made a txn where sender is a regular account and signed it with ```sh goal clerk sign -i tmp.txn -o tmp.txn -S BJATCHES5YJZJ7JITYMVLSSIQAVAWBQRVGPQUDT5AZ2QSLDSXWWM46THOY -p tmp.teal ``` I borked the git history on the last one algorand#3459 so just nuked it and starting over here. Left it at @tsachiherman wanting better tests for this algorand#3459 (comment)
In DevMode, do not create a block for internal events (i.e. compact-cert creation). This is to assure reproducibility and eliminate the random shifts in round numbers.
## Summary The existing Ledger.OnlineTotals is going ( at the end of the 320 project ), be using the onlineAccountsTracker to get its information from. But unlike the existing l.accts.Totals(rnd) call, it won't get the totals, but only the amount of online totals ( i.e. basics.MicroAlgos ). Prepare the Ledger implementation for that change by deprecating the accountUpdates.Totals and naming it OnlineTotals. As such, it would return just the online portion of that structure ( i.e. totals.Online.Money ). ## Test Plan Ran existing tests on Ledger.OnlineTotals
## Summary The changes in algorand#3770 didn't include the changes in algorand#3769 and so tests don't compile on master currently — this updates another test that uses `Totals` to use `LatestTotals` instead. ## Test Plan Fixes tests.
## Summary This PR upgrade the go-algorand repository to use go 1.16 while adding workarounds for golang/go#44343. ## Test Plan Use performance testing to verify no regressions.
## Summary update go(mod/sum) to use golang 1.16 on the following dependencies: 1. go-codec 2. go-deadlock 3. msgp 4. websocket 5. graphtrace 6. oapi-codegen ## Test Plan Use existing tests.
* remove slice nil handling, add comments to explain * update testcases * partition, dog
`goal` supports signing transactions on a Ledger device. This is done by using github.com/karalabe/usb which is deprecated. Since we go-algorand is being updated to 1.16 we update the library and manually test this version with Ledger. Tested `goal` with Ledger Nano X and S.
…gorand#3728) * nit: always set Exclude value in accountInformationParams * fix comments from CR
* This is a prerequisite test before retiring AccountData.OnlineAccountData() that is used only in tests agreement and committee tests. * Historically all these tests depends on genesis data that is basic.AccountData. * Our GA genesis files have stake, status and voting data and never had resources basic.AccountData can be reduced to the original stake + voting data state and a new basic.AccountDataEx can be introduced for using in REST API * Ledger tests and test network generation tools need to be updated to accept a new reduced (original) basic.AccountData as genesis and resource records for assets and apps needed for tests after the ledger initialization.
…tation (algorand#3856) * Revert "Revert `fillBytes` method to `bigIntToBytes` for lower golang version (algorand#3498)" * leadingZeros update * minor updates with elliptics * byteLength
* dont make array with length if we're just appending to it * make it ahead of time like other slice init in the same file * tweaking unit tests to be less forgiving to local deltas slice
Unify most assembly routines to minimize difference and ease doc gen Flexible opcode costs and fewer assembly routines Co-authored-by: michaeldiamant <michaeldiamant@users.noreply.github.com>
Also pretty print langsoec so that chnages are easier to see.
AllowV4InnerAppls also means that apps can not perform an inner opt-in to apps with <v4 CSP (since they might then be locked in). And no app can downgrade, as that is a straightforward rule to prevent an app from lowering its CSP and locking other apps into it. The DoubleLedger does a lot of double checking on ledgers produced by rerunning transactions after creating blocks, deserializing the txns from the block and validating the results. testConsensusRange makes it easy for ledger tests to test behavior in many protocol levels. A particular problem it handles is that test can be written to run from some consensus version and in every subsequent version. So if we change behavior in a new version, we'll find out. Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>
In order to run private networks in docker, it is convenient to mount the data directory. By disallowing the network directory to exist it is not possible to mount the node directory.
arm32 has int32 fields in Timespec struct, but Nanoseconds() returns int64. The new arm32-specific implementation of NanoSleep casts it to int32 as Timespec expects.
This is a quick fix. A better fix would replace this container with something more lightweight, as it's doing too much for this step.
In some situations the method might incorrectly count deleted items towards total items. This might result not returning all the resources to REST API clients.
Algo-devops-service
requested review from
algoanne,
algobarb,
algojack,
egieseke,
michaeldiamant and
onetechnical
Codecov Report
@@ Coverage Diff @@
## rel/stable #3960 +/- ##
==============================================
+ Coverage 49.78% 49.79% +0.01%
==============================================
Files 392 409 +17
Lines 68780 68897 +117
==============================================
+ Hits 34241 34309 +68
- Misses 30777 30887 +110
+ Partials 3762 3701 -61
Continue to review full report at Codecov.
|
michaeldiamant
approved these changes
May 9, 2022
There was a problem hiding this comment.
Looks reasonable though I assumed the PR's What's New should match #3947.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Maintenance release of incremental enhancements and fixes.
What's New
Changelog
New Features
Enhancements
fillBytesmethod in ABI and eval.go implementation (#3856)Bugfixes
Other
Protocol Upgrade
This release does not contain a protocol upgrade.
NOTE
vFuture changes are not yet available in MainNet or TestNet but can be used in private networks.
Additional Resources