Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Mac M1 support #3920

Closed
wants to merge 4 commits into from
Closed

Conversation

Eric-Warehime
Copy link
Contributor

Summary

Updates Makefile for Mac M1 support. Currently only requires changes to account for linking to libraries installed in the new homebrew location /opt/homebrew.

Requires #3919 (I've included that commit in this branch since without it the build will fail).

Test Plan

Built and running on my personal M1 machine.
Also needs #3813 for CI support.

@algorandskiy
Copy link
Contributor

Looks good. Looks like it spotted a data race in node.go

@@ -14,12 +14,15 @@ require (
github.com/aws/aws-sdk-go v1.16.5
github.com/chrismcguire/gobberish v0.0.0-20150821175641-1d8adb509a0e
github.com/cpuguy83/go-md2man v1.0.8 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of misc little changes in go.mod , was go mod tidy run?

@codecov-commenter
Copy link

Codecov Report

Merging #3920 (5d2152e) into master (f83e312) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3920      +/-   ##
==========================================
+ Coverage   49.79%   49.82%   +0.03%     
==========================================
  Files         409      409              
  Lines       68897    68903       +6     
==========================================
+ Hits        34305    34334      +29     
+ Misses      30888    30871      -17     
+ Partials     3704     3698       -6     
Impacted Files Coverage Δ
crypto/secp256k1/panic_cb.go 0.00% <ø> (ø)
crypto/secp256k1/scalar_mult_cgo.go 77.77% <ø> (ø)
crypto/secp256k1/secp256.go 42.25% <ø> (ø)
libgoal/lockedFileLinux.go 0.00% <ø> (ø)
libgoal/lockedFileUnix.go 0.00% <ø> (ø)
nodecontrol/kmdControl_common.go 0.00% <ø> (ø)
tools/network/dnssec/config_unix.go 72.72% <ø> (ø)
util/process_common.go 0.00% <ø> (ø)
util/util.go 0.00% <ø> (ø)
node/node.go 23.89% <100.00%> (+0.70%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f83e312...5d2152e. Read the comment docs.

@cce cce changed the title build: Mac M1 support build: Go 1.17 and Mac M1 support May 4, 2022
@cce cce changed the title build: Go 1.17 and Mac M1 support build: Mac M1 support May 4, 2022
@Eric-Warehime
Copy link
Contributor Author

I'm going to close this out since #3919 has ended up with the same set of changes and has the relevant review conversation in it. I originally thought it was going to be useful to separate the go updates and the M1 changes, but it doesn't seem productive at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

M1 Support: update configure_dev.sh
4 participants