build: Bump golang to 1.17.9/Mac M1 Support #3919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Eric-Warehime
force-pushed
the
golang-1.17-upgrade
branch
from
2c71aa3
to
92a739c
Compare
brianolson
reviewed
Apr 26, 2022
|
Additional commit modifies |
cce
reviewed
May 4, 2022
cce
reviewed
May 4, 2022
cce
reviewed
May 4, 2022
Eric-Warehime
changed the title
Eric-Warehime
force-pushed
the
golang-1.17-upgrade
branch
from
2e83ebb
to
da3fa3c
Compare
cce
added a commit
to cce/go-algorand
that referenced
this pull request
May 5, 2022
cce
added a commit
to cce/go-algorand
that referenced
this pull request
May 5, 2022
Eric-Warehime
force-pushed
the
golang-1.17-upgrade
branch
from
8b48dc5
to
4081315
Compare
winder
reviewed
May 9, 2022
| @@ -407,11 +407,11 @@ func (node *AlgorandFullNode) startMonitoringRoutines() { | |||
|
|
|||
| // PKI TODO: Remove this with #2596 | |||
| // Periodically check for new participation keys | |||
| go node.checkForParticipationKeys() | |||
| go node.checkForParticipationKeys(node.ctx.Done()) | |||
There was a problem hiding this comment.
@AlgoStephenAkiki fyi - there is going to be at least this merge conflict with your integration branch.
winder
reviewed
May 9, 2022
| @@ -1,6 +1,6 @@ | |||
| module github.com/algorand/go-algorand/scripts/buildtools | |||
|
|
|||
| go 1.16 | |||
| go 1.17 | |||
|
|
|||
| require ( | |||
| github.com/algorand/msgp v1.1.50 | |||
There was a problem hiding this comment.
This is where you'll update msgp after your other PR is merged and tagged
There was a problem hiding this comment.
@Eric-Warehime please update the version and I'll merge this
There was a problem hiding this comment.
Updated. Also had to run go get and go mod tidy which ended up separating deps into separate require blocks. See https://go-review.googlesource.com/c/go/+/325922/ and golang/go#45965 for details.
winder
reviewed
May 9, 2022
cce
previously approved these changes
May 9, 2022
algorandskiy
previously approved these changes
May 9, 2022
algorandskiy
approved these changes
May 9, 2022
algorandskiy
pushed a commit
that referenced
this pull request
May 17, 2022
This should ensure make msgp has been run for changes that impact msgp serialization on CI builds. It looks like #3829 was merged but missed changes to agreement/msgp_gen.go and gci updates from algorand/msgp#14 were not incorporated into #3919.
This was referenced May 27, 2022
This was referenced Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bump go version to 1.17.9 (latest 1.17 version).
It's good to upgrade compiler version regularly, but we also need this for #3808
Also includes
//+build=>//go:buildgenerated viamake sanity.Blocking merge on #3909 / #3917 which contains go1.16 version bump.
Test Plan
Run CI/Perf tests to benchmark against current version.