Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add simple codecov config #3997

Merged
merged 2 commits into from
May 18, 2022
Merged

CI: add simple codecov config #3997

merged 2 commits into from
May 18, 2022

Conversation

cce
Copy link
Contributor

@cce cce commented May 17, 2022

Summary

Since the codecov app was enabled, it is showing up in PR status checks. This adds a quick configuration based on https://docs.codecov.com/docs/commit-status that we can refine more later.

Test Plan

Status check should pick up changes.

@winder
Copy link
Contributor

winder commented May 17, 2022

FWIW, this is the configuration we came up with for with Indexer: https://github.com/algorand/indexer/blob/develop/.codecov.yml

algojack
algojack previously approved these changes May 17, 2022
Copy link
Contributor

@Eric-Warehime Eric-Warehime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Interested to see the output of the coverage checks. You might want to set the patch check to informational as well unless you want that failure to block reviews since I believe both patch and project are configured to run by default.

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #3997 (269c299) into master (91095fa) will increase coverage by 4.68%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3997      +/-   ##
==========================================
+ Coverage   49.77%   54.46%   +4.68%     
==========================================
  Files         409      390      -19     
  Lines       69157    48500   -20657     
==========================================
- Hits        34426    26415    -8011     
+ Misses      31011    19863   -11148     
+ Partials     3720     2222    -1498     
Impacted Files Coverage Δ
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
ledger/acctupdates.go 68.77% <0.00%> (-0.80%) ⬇️
catchup/service.go 68.88% <0.00%> (-0.75%) ⬇️
crypto/merklearray/msgp_gen.go
daemon/algod/api/spec/v2/msgp_gen.go
data/transactions/msgp_gen.go
data/committee/msgp_gen.go
crypto/merklesignature/msgp_gen.go
ledger/msgp_gen.go
data/bookkeeping/msgp_gen.go
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91095fa...269c299. Read the comment docs.

@cce
Copy link
Contributor Author

cce commented May 18, 2022

thanks @Eric-Warehime I added patch: too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants