Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: update node_exporter to support Linux diskstats #4047

Merged
merged 1 commit into from
May 26, 2022

Conversation

cce
Copy link
Contributor

@cce cce commented May 26, 2022

Summary

This updates the node_exporter binaries to include the fix in algorand/node_exporter#1 to correctly handle /proc/diskstats from Linux >= 5.5.

These binaries come from the artifacts from this Github Actions job: https://github.com/algorand/node_exporter/runs/6613401212

Test Plan

Tested as part of algorand/node_exporter#1.

@cce cce added the Bug-Fix label May 26, 2022
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #4047 (93e4bce) into master (7147d01) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4047      +/-   ##
==========================================
- Coverage   54.49%   54.46%   -0.04%     
==========================================
  Files         390      390              
  Lines       48620    48620              
==========================================
- Hits        26497    26482      -15     
- Misses      19902    19912      +10     
- Partials     2221     2226       +5     
Impacted Files Coverage Δ
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
ledger/tracker.go 74.45% <0.00%> (-2.17%) ⬇️
ledger/acctupdates.go 68.77% <0.00%> (-1.06%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
network/wsPeer.go 67.67% <0.00%> (-0.55%) ⬇️
catchup/service.go 68.88% <0.00%> (+0.74%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7147d01...93e4bce. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants