Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goal: Fix source map mappings key and use relative line values #4198

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

algochoi
Copy link
Contributor

Summary

This PR deprecates the previous mapping field and adds the mappings field to align itself closer to the sourcemap specs. In addition, it fixes the mappings so that it uses relative line values for the source line mapping.

Closes #4191 #4192

Test Plan

Added test to check the new field in the source map.

@algochoi algochoi marked this pull request as ready for review June 29, 2022 15:19
Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@algochoi Thanks for your efforts to address sourcemap spec deviations. ☕

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #4198 (0914f80) into master (ae17d8e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4198      +/-   ##
==========================================
+ Coverage   54.55%   54.59%   +0.03%     
==========================================
  Files         391      391              
  Lines       48788    48790       +2     
==========================================
+ Hits        26617    26636      +19     
+ Misses      19947    19935      -12     
+ Partials     2224     2219       -5     
Impacted Files Coverage Δ
data/transactions/logic/sourcemap.go 100.00% <100.00%> (ø)
network/wsPeer.go 67.67% <0.00%> (-0.28%) ⬇️
ledger/acctupdates.go 69.56% <0.00%> (+0.13%) ⬆️
network/wsNetwork.go 64.89% <0.00%> (+0.19%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
ledger/tracker.go 76.62% <0.00%> (+3.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae17d8e...0914f80. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sourcemap: Support relative segment field values
3 participants