Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: un-shadow loadgen privateKeys var #4380

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

brianolson
Copy link
Contributor

Summary

I am sad that go vet didn't have a warning about this shadowing of a variable name.

Test Plan

Manual test tool was tested manually.

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #4380 (defbd4b) into master (60fb4f6) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4380   +/-   ##
=======================================
  Coverage   55.60%   55.60%           
=======================================
  Files         403      403           
  Lines       50801    50801           
=======================================
+ Hits        28248    28250    +2     
+ Misses      20159    20156    -3     
- Partials     2394     2395    +1     
Impacted Files Coverage Δ
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
data/transactions/verify/txn.go 43.85% <0.00%> (-0.88%) ⬇️
ledger/acctonline.go 78.47% <0.00%> (-0.53%) ⬇️
catchup/service.go 68.88% <0.00%> (-0.50%) ⬇️
network/wsNetwork.go 64.70% <0.00%> (-0.20%) ⬇️
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
data/abi/abi_type.go 88.62% <0.00%> (+0.94%) ⬆️
util/db/dbutil.go 50.30% <0.00%> (+1.21%) ⬆️
... and 3 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants