Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StateProofs: Sp verification-tracker last lookup cache #4780

Merged
merged 10 commits into from
Nov 10, 2022
Merged

StateProofs: Sp verification-tracker last lookup cache #4780

merged 10 commits into from
Nov 10, 2022

Conversation

algonathan
Copy link
Contributor

Summary

Test Plan

@algonathan algonathan self-assigned this Nov 10, 2022
@id-ms id-ms changed the title algorand: Sp verification-tracker last lookup cache StateProofs: Sp verification-tracker last lookup cache Nov 10, 2022
@codecov
Copy link

codecov bot commented Nov 10, 2022 •
edited
Loading

Codecov Report

Merging #4780 (d5a73da) into feature/stateproofs-recoverability (0bd34b8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@                          Coverage Diff                           @@
##           feature/stateproofs-recoverability    #4780      +/-   ##
======================================================================
- Coverage                               54.68%   54.66%   -0.02%     
======================================================================
  Files                                     415      415              
  Lines                                   53805    53822      +17     
======================================================================
- Hits                                    29424    29423       -1     
- Misses                                  21934    21943       +9     
- Partials                                 2447     2456       +9
Impacted Files Coverage Δ
ledger/stateproofverificationtracker.go 93.96% <100.00%> (+1.03%) ⬆️
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
ledger/catchpointtracker.go 59.85% <0.00%> (-0.75%) ⬇️
network/wsPeer.go 68.44% <0.00%> (-0.49%) ⬇️
ledger/acctupdates.go 68.97% <0.00%> (-0.25%) ⬇️
ledger/accountdb.go 72.48% <0.00%> (-0.15%) ⬇️
network/wsNetwork.go 65.34% <0.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

id-ms
id-ms reviewed Nov 10, 2022
View reviewed changes
ledger/accountdb.go Outdated Show resolved Hide resolved
ledger/stateproofverificationtracker.go Show resolved Hide resolved
ledger/stateproofverificationtracker.go Outdated Show resolved Hide resolved
@algonathan
fix: checks cache location moved
e304d46 
removed unneeded sql lookup on reload from disk
fixed comments
fix: zero-cache is ignored
@algonathan
removed comment from function
d5a73da
@id-ms id-ms merged commit 687258f into algorand:feature/stateproofs-recoverability Nov 10, 2022
@onetechnical onetechnical mentioned this pull request Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@id-ms id-ms id-ms approved these changes

@almog-t almog-t Awaiting requested review from almog-t

Assignees

@algonathan algonathan

Labels
Team Sphinx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@algonathan @id-ms