Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algod: Delete deprecated cost field in dyrun response and mapping field in sourcemap #4875

Merged
merged 4 commits into from Dec 8, 2022

Conversation

algochoi
Copy link
Contributor

@algochoi algochoi commented Dec 7, 2022

Summary

This PR deletes deprecated fields in the v2 API:

  • cost field in DryrunTxnResult
  • Delete mapping field from sourcemap object

Part of algorand/algorand-sdk-testing#201

Test Plan

CI Tests

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #4875 (25ee88c) into master (265fd9f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4875      +/-   ##
==========================================
- Coverage   53.94%   53.93%   -0.02%     
==========================================
  Files         425      425              
  Lines       53256    53251       -5     
==========================================
- Hits        28731    28722       -9     
  Misses      22265    22265              
- Partials     2260     2264       +4     
Impacted Files Coverage Δ
cmd/goal/clerk.go 8.77% <ø> (+0.02%) ⬆️
daemon/algod/api/server/v2/dryrun.go 71.34% <ø> (-0.18%) ⬇️
data/transactions/logic/sourcemap.go 100.00% <100.00%> (ø)
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
ledger/tracker.go 74.26% <0.00%> (-0.85%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
ledger/acctonline.go 78.29% <0.00%> (-0.52%) ⬇️
network/wsNetwork.go 64.74% <0.00%> (-0.18%) ⬇️
network/wsPeer.go 71.36% <0.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algochoi algochoi marked this pull request as ready for review December 7, 2022 20:58
@algochoi algochoi changed the title algod: Delete cost field in dyrun response and usage in goal algod: Delete deprecated cost field in dyrun response and mapping field in sourcemap Dec 7, 2022
michaeldiamant
michaeldiamant previously approved these changes Dec 8, 2022
Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@algochoi Looks appropriate on my end - thanks for bundling these algod REST API changes alongside #4847.

ahangsu
ahangsu previously approved these changes Dec 8, 2022
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahangsu
Copy link
Contributor

ahangsu commented Dec 8, 2022

oh boy, you should probably merge master to resolve the conflict in routes.go...

@algochoi
Copy link
Contributor Author

algochoi commented Dec 8, 2022

Thanks for the bump! Re-requested for review after merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants