New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
algod: Delete deprecated cost field in dyrun response and mapping field in sourcemap #4875
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4875 +/- ##
==========================================
- Coverage 53.94% 53.93% -0.02%
==========================================
Files 425 425
Lines 53256 53251 -5
==========================================
- Hits 28731 28722 -9
Misses 22265 22265
- Partials 2260 2264 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
oh boy, you should probably merge master to resolve the conflict in |
Thanks for the bump! Re-requested for review after merging |
Summary
This PR deletes deprecated fields in the v2 API:
cost
field inDryrunTxnResult
mapping
field fromsourcemap
objectPart of algorand/algorand-sdk-testing#201
Test Plan
CI Tests