go-algorand v3.13.0-stable Release PR #4890

Algo-devops-service · 2022-12-12T16:57:07Z

Overview

Performance improvements and deprecation of v1 endpoints are the highlights of this release.

What's New

Drop support for algod v1 REST API. v1 endpoints now return a 410 code to make explicit the API reached end-of-life. The replacement is https://developer.algorand.org/docs/rest-apis/algod/v2/ .
Breaking changes to algod v2 REST API - These previously deprecated response fields are removed:
- https://developer.algorand.org/docs/rest-apis/algod/v2/#post-v2tealdryrun - cost (https://github.com/algorand/go-algorand/pull/4875/files#diff-4dbbc679cc9edab4510c8be1d215ec85830b5a5cfba57ac1379501cbeb3911d0L3227).
- https://developer.algorand.org/docs/rest-apis/algod/v2/#post-v2tealcompile - sourcemap.mapping (https://github.com/algorand/go-algorand/pull/4875/files#diff-70eb30d34776b4cd7c752fef5b8aad5363a3648e46466331e7d2e6173744bc99L40).
Continued performance improvements:
- Early duplicates detection in txHandler (#4806)
- Metrics added for txpool.Remember in txHandler (#4839)
- Metrics added for errors returned by checkAlreadyCommitted (#4881)
Bug fix: 64-bit alignment of groupTasks (#4876)
Promote trie-related log warnings to errors (#4882)

Changelog

New Features

Goal: account deletepartkey subcomand (#4788)
Ledger Deltas: AccountDelta retrieval through ledger/catchup service (#4658)

Enhancements

Algod: Delete deprecated cost field in dyrun response and mapping field in sourcemap (#4875)
Algod: Sunset v1 handlers (#4847)
Catchpoint: Promote trie-related log warnings to error (#4882)
Docker: General purpose docker container. (#4816)
Goal: Test ABI reference arguments during creation (#4872)
Ledger: add context to block mismatch error in VerifyCatchpoint (#4821)
Metrics: add counters for checkAlreadyCommitted, split "InLedger" counters by reason (#4881)
Node: Fix disabled node tests (#4824)
Performance: Implement sync.Pool for cow.child() (#4766)
Tests: Extend TestCatchpointAfterTxns to catch catchpoint write corruption (#4818)
Txhandler: metrics for txpool.Remember (#4839)
Txhandler: early duplicates detection (#4806)
Txhandler: upgraded benchmarks (#4834)
Updater: use more-recent installer package (#4734)

Bugfixes

Bug-fix: upgrade AVM-abi (#4838)
Catchpoint: Fix broken merge between Tests: Extend TestCatchpointAfterTxns to catch catchpoint write corruption #4818 and ledger: move catchpoint related methods into a storage package #4835 (#4840)
Ci: Fix some details around the hashKind -> HashKind change (#4865)
Prefetcher: preallocate aligned groupTasks in groupsReady (#4876)

Protocol Upgrade

This release does not contain a protocol upgrade.

Additional Resources

…4776)

…rand#4821)

…and#4835)

…ption (algorand#4818)

…lgorand#4840)

…-remerge

…12.2-remerge CICD: go-algorand relstable3.12.2-remerge mergeback

* Add setting incoming transaction rate * Add backlog worker with transaction dropping * Count dropped transactions

…lgorand#4658) Co-authored-by: shiqizng <80276844+shiqizng@users.noreply.github.com> Co-authored-by: michaeldiamant <michaeldiamant@users.noreply.github.com> Co-authored-by: Will Winder <wwinder.unh@gmail.com>

…#4865) * Fix some details around the hashKind -> HashKind change * CI should do full `make generate`

Add tx message duplicates detection in txHandler: * Network raw messages with blake2b + salt auto-rotating hash map * Canonical reencoded tx groups with sha512_256 hash map Configurable with TxIncomingFilteringFlags Co-authored-by: chris erway <chris.erway@algorand.com> Co-authored-by: algonautshant <shant@algorand.com>

…rand#4864)

…ld in sourcemap (algorand#4875)

* breakdown of eval vs block for lease/txID errors

)

codecov · 2022-12-12T17:22:21Z

Codecov Report

Merging #4890 (0c126f6) into rel/stable (3583908) will decrease coverage by 0.08%.
The diff coverage is 71.27%.

@@              Coverage Diff               @@
##           rel/stable    #4890      +/-   ##
==============================================
- Coverage       54.67%   54.59%   -0.09%     
==============================================
  Files             421      431      +10     
  Lines           53790    53560     -230     
==============================================
- Hits            29409    29240     -169     
- Misses          21968    22029      +61     
+ Partials         2413     2291     -122

Impacted Files	Coverage Δ
cmd/goal/clerk.go	`8.77% <ø> (+0.02%)`	⬆️
config/config.go	`48.52% <ø> (ø)`
config/version.go	`9.09% <ø> (ø)`
crypto/batchverifier.go	`100.00% <ø> (ø)`
daemon/algod/api/server/router.go	`13.88% <ø> (ø)`
daemon/algod/api/server/v2/dryrun.go	`71.34% <ø> (-0.18%)`	⬇️
daemon/algod/api/server/v2/handlers.go	`0.87% <0.00%> (-0.04%)`	⬇️
data/pools/errors.go	`0.00% <0.00%> (ø)`
data/transactions/transaction.go	`43.04% <0.00%> (ø)`
ledger/accountdb.go	`76.47% <ø> (+4.11%)`	⬆️
... and 82 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

algobarb · 2022-12-12T18:08:25Z

we should probably fix up the What's New section...
Beta Release Notes: https://github.com/algorand/go-algorand/releases/tag/v3.13.0-beta

algobarb

LGTM

michaeldiamant

As intended - matches commits + description from #4885.

icorderi and others added 30 commits November 21, 2022 16:28

ledger: move pieces of accountdb.go into a storage package (algorand#…

60d0c09

…4776)

test: disable TestWebsocketNetworkTelemetryTCP on CI (algorand#4827)

fd9bd68

ledger: move catchpoint sql code into storage package (algorand#4813)

ee04a46

ledger: add context to block mismatch error in VerifyCatchpoint (algo…

9f466c0

…rand#4821)

performance: implement sync.Pool for cow.child() (algorand#4766)

1c68f10

ledger: move non-lookup methods into a storage package (algorand#4830)

1cf857f

metrics: count large txn groups and msigs (algorand#4833)

381a835

node: fix disabled node tests (algorand#4824)

3a5e584

ledger: move catchpoint related methods into a storage package (algor…

a00e8a5

…and#4835)

Bug-Fix: upgrade avm-abi (algorand#4838)

8327fc7

Tests: Extend TestCatchpointAfterTxns to catch catchpoint write corru…

143496a

…ption (algorand#4818)

Catchpoint: Fix broken merge between algorand#4818 and algorand#4835 (a…

d19f2aa

…lgorand#4840)

ledger: move catchpoint staging into a storage package (algorand#4836)

7aa2f8c

Merge remote-tracking branch 'origin/rel/stable' into relstable3.12.2…

ac9eb9f

…-remerge

Bump Version, Remove buildnumber.dat and genesistimestamp.dat files.

9d1cc55

Merge pull request algorand#4843 from Algo-devops-service/relstable3.…

e8b1416

…12.2-remerge CICD: go-algorand relstable3.12.2-remerge mergeback

txHandler: upgraded benchmarks (algorand#4834)

3abde76

* Add setting incoming transaction rate * Add backlog worker with transaction dropping * Count dropped transactions

updater: use more-recent installer package (algorand#4734)

6acecbd

ledger: move blockdb into a storage package (algorand#4841)

a70260d

Ledger Deltas: AccountDelta retrieval through ledger/catchup service (a…

7b09c65

…lgorand#4658) Co-authored-by: shiqizng <80276844+shiqizng@users.noreply.github.com> Co-authored-by: michaeldiamant <michaeldiamant@users.noreply.github.com> Co-authored-by: Will Winder <wwinder.unh@gmail.com>

CI: Fix some details around the hashKind -> HashKind change (algorand…

ffa688a

…#4865) * Fix some details around the hashKind -> HashKind change * CI should do full `make generate`

goal: account deletepartkey subcomand (algorand#4788)

6e26b0d

ledger: move migrations into a storage package (algorand#4846)

00cf6be

ledger: move blockdb tests into storage package (algorand#4860)

8515e46

algod: Sunset v1 handlers (algorand#4847)

0f66b33

Goal: Test ABI reference arguments during creation (algorand#4872)

265fd9f

ledger: new db methods to abstract queries needed by the deltas (algo…

ebe4e80

…rand#4864)

DevOps: General purpose docker container. (algorand#4816)

c0c5a94

txHandler: metrics for txpool.Remember (algorand#4839)

cebda47

algorandskiy and others added 10 commits December 8, 2022 14:47

txHandler: disable canonical hashmap by default (algorand#4877)

697c811

algod: Delete deprecated cost field in dyrun response and mapping fie…

c0e044b

…ld in sourcemap (algorand#4875)

metrics: fix TestGetValue (algorand#4879)

93c01b5

metrics: add counters for checkAlreadyCommitted (algorand#4881)

4e58dbd

* breakdown of eval vs block for lease/txID errors

tests: skip flaky node tests (algorand#4862)

829a3c9

algod: Remove unused generated code (algorand#4880)

58a1532

prefetcher: preallocate aligned groupTasks in groupsReady (algorand#4876

4dd9877

)

catchpoint: promote MT-related log warnings to error (algorand#4882)

10d3710

Update the Version, BuildNumber, genesistimestamp.data

64386e3

Merge pull request algorand#4885 from Algo-devops-service/relbeta3.13.0

0c126f6

onetechnical changed the title ~~go-algorand 3.13.0-stable Release PR~~ go-algorand v3.13.0-stable Release PR Dec 12, 2022

algobarb approved these changes Dec 12, 2022

View reviewed changes

michaeldiamant approved these changes Dec 12, 2022

View reviewed changes

algojohnlee merged commit e04c13b into algorand:rel/stable Dec 12, 2022

onetechnical deleted the relstable3.13.0 branch December 12, 2022 19:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

go-algorand v3.13.0-stable Release PR #4890

go-algorand v3.13.0-stable Release PR #4890

Algo-devops-service commented Dec 12, 2022 •

edited by onetechnical

codecov bot commented Dec 12, 2022 •

edited

algobarb commented Dec 12, 2022 •

edited

algobarb left a comment

michaeldiamant left a comment

go-algorand v3.13.0-stable Release PR #4890

go-algorand v3.13.0-stable Release PR #4890

Conversation

Algo-devops-service commented Dec 12, 2022 • edited by onetechnical

Overview

What's New

Changelog

New Features

Enhancements

Bugfixes

Protocol Upgrade

Additional Resources

codecov bot commented Dec 12, 2022 • edited

Codecov Report

algobarb commented Dec 12, 2022 • edited

algobarb left a comment

Choose a reason for hiding this comment

michaeldiamant left a comment

Choose a reason for hiding this comment

Algo-devops-service commented Dec 12, 2022 •

edited by onetechnical

codecov bot commented Dec 12, 2022 •

edited

algobarb commented Dec 12, 2022 •

edited