-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(algocfg): add development profile and profile descriptions. #5164
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5164 +/- ##
==========================================
- Coverage 53.63% 53.59% -0.04%
==========================================
Files 437 437
Lines 54934 54947 +13
==========================================
- Hits 29463 29451 -12
- Misses 23191 23210 +19
- Partials 2280 2286 +6
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmd/algocfg/profileCommand.go
Outdated
cfg.MaxAcctLookback = 16 | ||
cfg.CatchupParallelBlocks = 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our perf tests, I've been using the following:
cfg.CatchupParallelBlocks = 64
cfg.EnableFollowMode = true
cfg.MaxAcctLookback = 64
Also worth noting that the test script sets
cfg. CatchupBlockValidateMode = 3
which will probably speed up catchup, but has some trust implications obviously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description no longer matches, but seems good otherwise.
Summary
Update
algocfg profile
command:list
subcommand.Descriptions:
Documentation