AVM: Avoid panics in disassembly when branch instructions are short #5252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5252 +/- ##
===========================================
- Coverage 53.75% 39.71% -14.05%
===========================================
Files 450 450
Lines 56191 56199 +8
===========================================
- Hits 30207 22318 -7889
- Misses 23632 31531 +7899
+ Partials 2352 2350 -2
... and 252 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bbroder-algo
reviewed
Apr 3, 2023
bbroder-algo
reviewed
Apr 3, 2023
bbroder-algo
previously approved these changes
Apr 3, 2023
ahangsu
reviewed
Apr 4, 2023
ahangsu
approved these changes
Apr 4, 2023
bbroder-algo
approved these changes
Apr 4, 2023
This was referenced May 9, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it is not a security problem, it's poor form to panic rather than return a nice error when disassembling bad programs. The disassembler was unconditionally trying to decode the labels of branching opcodes without checking to see if the program was long enough to hold them.