-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVM: Avoid panics in disassembly when branch instructions are short #5252
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5252 +/- ##
===========================================
- Coverage 53.75% 39.71% -14.05%
===========================================
Files 450 450
Lines 56191 56199 +8
===========================================
- Hits 30207 22318 -7889
- Misses 23632 31531 +7899
+ Partials 2352 2350 -2
... and 252 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally lgtm, have some questions on testcases
Although it is not a security problem, it's poor form to panic rather than return a nice error when disassembling bad programs. The disassembler was unconditionally trying to decode the labels of branching opcodes without checking to see if the program was long enough to hold them.