bugfix: reduce flakiness in follower node test #5355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
commented
May 3, 2023
winder
reviewed
May 3, 2023
winder
approved these changes
May 3, 2023
Codecov Report
@@ Coverage Diff @@
## master #5355 +/- ##
=======================================
Coverage 55.29% 55.30%
=======================================
Files 454 454
Lines 63713 63713
=======================================
+ Hits 35231 35234 +3
+ Misses 26090 26087 -3
Partials 2392 2392 see 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shiqizng
approved these changes
May 5, 2023
|
I just bumped it to 20s in #5361 |
This was referenced May 9, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TestSyncRoundWithRemakecan fail supuriously in CI as seen here:https://app.circleci.com/pipelines/github/algorand/go-algorand/14091/workflows/0ef0821c-f9df-45ae-b5bf-a28cab0aca2f/jobs/229564/parallel-runs/0?filterBy=FAILED&invite=true#step-114-6149
interpretation of the failure
0xc8)0xc3)The proposed fix is to wait for the follower node to catch up to the expected round. The test may still timeout, but it's expected to occur much less frequently then the current failure condition.
Test Plan
CI