test: remove follower node flaky TestSyncRoundWithRemake #5415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
approved these changes
May 23, 2023
Codecov Report
@@ Coverage Diff @@
## master #5415 +/- ##
==========================================
- Coverage 55.40% 55.31% -0.09%
==========================================
Files 452 452
Lines 63855 63855
==========================================
- Hits 35379 35322 -57
- Misses 26044 26099 +55
- Partials 2432 2434 +2 see 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Eric-Warehime
approved these changes
May 24, 2023
algorandskiy
changed the title
This was referenced May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove a flaky unit test which after repeated adjustments is still failing unpredictably: https://app.circleci.com/pipelines/github/algorand/go-algorand/14526/workflows/a474572e-62d9-49a2-8f05-e012f74926dc/jobs/235063?invite=true#step-114-6862
Related PR's
Test Plan
The same feature has test coverage in a more reliable end-to-end test:
go-algorand/test/e2e-go/features/followerNode/syncRestart_test.go
Line 31 in 5f2d5ed