Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p: adding peerstore #5576

Merged
merged 10 commits into from Jul 28, 2023
Merged

p2p: adding peerstore #5576

merged 10 commits into from Jul 28, 2023

Conversation

shiqizng
Copy link
Contributor

@shiqizng shiqizng commented Jul 18, 2023 •
edited by jsgranados

This PR adds a peerstore module.

Info

Closes #5544

@shiqizng shiqizng self-assigned this Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023 •
edited

Codecov Report

Merging #5576 (a4ba318) into master (d316914) will increase coverage by 0.05%.
The diff coverage is 87.87%.

@@            Coverage Diff             @@
##           master    #5576      +/-   ##
==========================================
+ Coverage   55.79%   55.84%   +0.05%     
==========================================
  Files         446      448       +2     
  Lines       63418    63451      +33     
==========================================
+ Hits        35381    35437      +56     
+ Misses      25668    25651      -17     
+ Partials     2369     2363       -6
Impacted Files Coverage Δ
network/p2p/peerstore/peerstore.go 86.66% <86.66%> (ø)
network/p2p/peerstore/utils.go 88.88% <88.88%> (ø)

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shiqizng shiqizng marked this pull request as ready for review July 18, 2023 15:31
@shiqizng shiqizng requested review from a team, cce and iansuvak July 18, 2023 15:31
tzaffi
tzaffi reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very promising and clean!

I made some suggestions regarding adding test cases and wrapping errors from external libraries with our own messages to improve debuggability.

network/peerstore/peerstore_test.go Outdated Show resolved Hide resolved
network/peerstore/peerstore_test.go Outdated Show resolved Hide resolved
network/peerstore/peerstore.go Outdated Show resolved Hide resolved
network/peerstore/peerstore.go Outdated Show resolved Hide resolved
network/peerstore/peerstore.go Outdated Show resolved Hide resolved
network/peerstore/peerstore.go Outdated Show resolved Hide resolved
network/peerstore/peerstore.go Outdated Show resolved Hide resolved
network/peerstore/peerstore.go Outdated Show resolved Hide resolved
Eric-Warehime
Eric-Warehime reviewed Jul 18, 2023
View reviewed changes
network/peerstore/peerstore.go Outdated Show resolved Hide resolved
network/peerstore/peerstore.go Outdated Show resolved Hide resolved
network/peerstore/peerstore.go Outdated Show resolved Hide resolved
@winder winder changed the title enhancement: adding peerstore p2p: adding peerstore Jul 19, 2023
Eric-Warehime
Eric-Warehime reviewed Jul 20, 2023
View reviewed changes
network/p2p/peerstore/peerstore.go Outdated Show resolved Hide resolved
network/p2p/peerstore/peerstore.go Outdated Show resolved Hide resolved
tzaffi
tzaffi previously approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous questions have been addressed and new questions don't block.

Eric-Warehime
Eric-Warehime approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@Eric-Warehime Eric-Warehime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge this now. We can adjust any things which end up needing changes in any future PRs as necessary.

cce
cce reviewed Jul 24, 2023
View reviewed changes
go.mod Show resolved Hide resolved
cce
cce reviewed Jul 24, 2023
View reviewed changes
go.mod Show resolved Hide resolved
@algorandskiy algorandskiy merged commit 3f32d61 into algorand:master Jul 28, 2023
18 checks passed
@jsgranados jsgranados added the p2p Work related to the p2p project label Aug 3, 2023
@cce cce mentioned this pull request Aug 14, 2023
Merged
This was referenced Aug 17, 2023
Closed
Merged
This was referenced Aug 19, 2023
Closed
Merged
@Algo-devops-service Algo-devops-service mentioned this pull request Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cce cce cce left review comments

@winder winder winder approved these changes

@iansuvak iansuvak iansuvak approved these changes

@Eric-Warehime Eric-Warehime Eric-Warehime approved these changes

@tzaffi tzaffi tzaffi left review comments

Assignees

@shiqizng shiqizng

Labels
Enhancement p2p Work related to the p2p project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement peerstore
8 participants
@shiqizng @cce @winder @tzaffi @iansuvak @Eric-Warehime @algorandskiy @jsgranados