network: add P2PNetwork implementation #5640
Conversation
cce
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5640 +/- ##
==========================================
- Coverage 55.47% 55.35% -0.12%
==========================================
Files 466 473 +7
Lines 65642 66075 +433
==========================================
+ Hits 36413 36579 +166
- Misses 26785 27039 +254
- Partials 2444 2457 +13
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
added
New Feature
p2p
There was a problem hiding this comment.
Nice start, I think this will get us most of the way to an initial test!
Some general comments at this point.
- I think we should remove all of the Todo comments. Let's capture them in issues if we need to, and make sure things are relatively clean as we commit them.
- Needs more test coverage.
- Might be helpful to commit alongside this some readme or diagram which explains how things are structured in terms of the different gossipsub topics/what they are used for, and the things we're running through streams.
|
I support a diagram, I hope it's public |
Co-authored-by: shiqizng <80276844+shiqizng@users.noreply.github.com>
… support for -p multiaddr
replace context.TODO()s
|
Remerged master and disabled the FiveNode E2E test. It's currently failing because of a timing issue that nodes are unable to recover from because HTTP block service is not yet implemented. This will be solved in a future PR. |
Co-authored-by: Pavel Zbitskiy <65323360+algorandskiy@users.noreply.github.com>
|
@Eric-Warehime @pao-beep added a README with a diagram |
There was a problem hiding this comment.
Approving as a second reviewer since @algorandskiy approved recently and the only change since was the readme and a single line suggestion by him.
cce
dismissed stale reviews from algorandskiy, shiqizng, and iansuvak
via
0dd20aa
Summary
Following up on #5634, this adds a new GossipNode implementation (P2PNetwork) which integrates with the libp2p support packages in network/p2p.
Test Plan
Added new tests TestP2PSubmitTX and TestP2PSubmitWS, also tested nodes connecting with each other manually using
goal node start -p. Added a basic 10-round test in test/e2e-go/features/p2p package along with 2-, 3-, and 5-node templates to start E2E testing.