Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: in-memory peerstore #5664

Merged
merged 4 commits into from Aug 15, 2023
Merged

p2p: in-memory peerstore #5664

merged 4 commits into from Aug 15, 2023

Conversation

shiqizng
Copy link
Contributor

This PR changes the peerstore to use the in-memory version. #5650.

@shiqizng shiqizng self-assigned this Aug 14, 2023
@shiqizng shiqizng added Team Lamprey Enhancement p2p Work related to the p2p project labels Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #5664 (cf73510) into master (435532d) will decrease coverage by 0.02%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5664      +/-   ##
==========================================
- Coverage   55.10%   55.09%   -0.02%     
==========================================
  Files         464      464              
  Lines       64973    64967       -6     
==========================================
- Hits        35806    35793      -13     
  Misses      26780    26780              
- Partials     2387     2394       +7     
Files Changed Coverage Δ
network/p2p/peerstore/peerstore.go 77.77% <100.00%> (-8.89%) ⬇️

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Eric-Warehime
Eric-Warehime previously approved these changes Aug 14, 2023
iansuvak
iansuvak previously approved these changes Aug 15, 2023
Copy link
Contributor

@iansuvak iansuvak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but looks like we'll have another tiny merge conflict based on recent changes in #5640

@winder winder merged commit 3425e85 into algorand:master Aug 15, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement p2p Work related to the p2p project Team Lamprey
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants