Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to including Python go-algorand E2E tests in buildtestdata.sh #888

Merged

Conversation

michaeldiamant
Copy link
Contributor

Summary

Default to including Python go-algorand E2E tests in buildtestdata.sh.

  • Prior to the PR, buildtestdata.sh did not include go-algorand E2E tests. The PR closes the test coverage gap.
  • Additionally, exposes an environment variable to simplify user control of included tests. The exposed configuration improves workflows for local testing on select tests.

Test Plan

Example invocation with default INDEXER_BTD_TESTS:

michael@albode indexer % bash misc/buildtestdata.sh
+ set -e
+ '[' -z '' ']'
+ echo 'Using default GOALGORAND'
Using default GOALGORAND
+ GOALGORAND=/Users/michael/.asdf/installs/golang/1.14.15/packages/src/github.com/algorand/go-algorand
+ '[' -z '' ']'
+ echo 'Using default E2EDATA'
Using default E2EDATA
+ E2EDATA=/Users/michael/Algorand/e2edata
+ tests='test/scripts/e2e_subs/{*.py,*.sh}'
+ echo 'Configured tests = test/scripts/e2e_subs/{*.py,*.sh}'
Configured tests = test/scripts/e2e_subs/{*.py,*.sh}

Example invocation with override specified:

michael@albode indexer % export INDEXER_BTD_TESTS="test/scripts/e2e_subs/app-inner-calls.py"
michael@albode indexer % bash misc/buildtestdata.sh
+ set -e
+ '[' -z '' ']'
+ echo 'Using default GOALGORAND'
Using default GOALGORAND
+ GOALGORAND=/Users/michael/.asdf/installs/golang/1.14.15/packages/src/github.com/algorand/go-algorand
+ '[' -z '' ']'
+ echo 'Using default E2EDATA'
Using default E2EDATA
+ E2EDATA=/Users/michael/Algorand/e2edata
+ tests=test/scripts/e2e_subs/app-inner-calls.py
+ echo 'Configured tests = test/scripts/e2e_subs/app-inner-calls.py'
Configured tests = test/scripts/e2e_subs/app-inner-calls.py

@michaeldiamant michaeldiamant merged commit 860ed09 into algorand:develop Feb 18, 2022
@michaeldiamant michaeldiamant deleted the buildtestdata_python_tests branch February 18, 2022 17:37
michaeldiamant added a commit to michaeldiamant/indexer that referenced this pull request Feb 18, 2022
algorand#888 introduces a bug due to bash's ordering of brace and parameter expansion.  The commit supports parameter expansion at the expense of dropping the environment variable.  I'll restore external configuration in a subsequent PR.
michaeldiamant added a commit that referenced this pull request Feb 18, 2022
#888 introduces a bug due to bash's ordering of brace and parameter expansion.  The commit supports parameter expansion at the expense of dropping the environment variable.  

I'll restore external configuration in a subsequent PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants