Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test upgrade algod and indexer images to Go 1.17 #319

Closed
wants to merge 1 commit into from
Closed

Test upgrade algod and indexer images to Go 1.17 #319

wants to merge 1 commit into from

Conversation

michaeldiamant
Copy link
Contributor

Tests algorand/algorand-sdk-testing#177.

I do not plan to merge. Closing upon successful test.

@michaeldiamant
Copy link
Contributor Author

Test is successful - Build passes. Closing PR.

For completeness, here's an example failed build: https://app.circleci.com/pipelines/github/algorand/java-algorand-sdk/100/workflows/0a81b974-8539-4d86-9c01-d47c98304f41/jobs/187.

And the error:

../../third_party/go-algorand/data/abi/abi_encode.go:179:8: bigInt.FillBytes undefined (type *big.Int has no field or method FillBytes)
note: module requires Go 1.17
make: *** [Makefile:27: cmd/algorand-indexer/algorand-indexer] Error 2

@michaeldiamant michaeldiamant deleted the upgrade_golang_1.17 branch May 12, 2022 16:44
@michaeldiamant michaeldiamant mentioned this pull request May 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@michaeldiamant