Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade algod and indexer images to Go 1.17 #177

Merged
merged 2 commits into from
May 12, 2022
Merged

Upgrade algod and indexer images to Go 1.17 #177

merged 2 commits into from
May 12, 2022

Conversation

michaeldiamant
Copy link
Contributor

Updates algod and indexer images to support Go v1.17.

Relates to these PRs:

@michaeldiamant michaeldiamant mentioned this pull request May 12, 2022
Closed
@michaeldiamant
Copy link
Contributor Author

Testing via algorand/java-algorand-sdk#319 (comment) worked as expected. Marking PR ready for review.

@michaeldiamant michaeldiamant marked this pull request as ready for review May 12, 2022 16:44
algoidurovic
algoidurovic approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@algoidurovic algoidurovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe it would be worthwhile to look into why the golang version typo wasn't causing a test failure.

@michaeldiamant
Copy link
Contributor Author

why the golang version typo wasn't causing a test failure.

  • docker/algod/source/Dockerfile isn't referenced by docker-compose.yml, which explains the absence of downstream build failure.
  • Locally, I confirmed the PR builds successfully via docker build -f docker/algod/source/Dockerfile ..

winder
winder approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaeldiamant michaeldiamant merged commit 8d7af8c into master May 12, 2022
@michaeldiamant michaeldiamant deleted the upgrade_golang_1.17 branch May 12, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winder winder winder approved these changes

@algoidurovic algoidurovic algoidurovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaeldiamant @winder @algoidurovic