Allow LogicSigs to sign txns with a different AuthAddr #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
force-pushed
the
jason/allow-logicsig-rekey
branch
from
c1ea8fa
to
236664d
Compare
jasonpaulos
force-pushed
the
jason/allow-logicsig-rekey
branch
from
236664d
to
a52f3d2
Compare
algorotem
reviewed
Feb 10, 2021
| const actual = algosdk.signLogicSigTransaction(txn, lsig); | ||
| const expected = { | ||
| txID: 'A6G4CMEV7QHLTMWDGU6BRYYVG3IXSSFTVDISEPALUHKIP4DNHQ4A', | ||
| blob: new Uint8Array(Buffer.from('g6Rsc2lngaFsxAUBIAEBIqRzZ25yxCD2di2sdbGZfWwslhgGgFB0kNeVES/+f7dgsnOK+cfxraN0eG6Ko2FtdM0DT6NmZWXNCniiZnYzomdoxCAmCyAJoJOohot5WHIvpeVG7eftF+TYXEx4r7BFJpDt0qJsdj2kbm90ZcQDewzIo3JjdsQgoImqaSLjuZj63/bNSAjd+eAh5JROOJ6j1cY4eGaJGX6lcmVrZXnEIDAhUOuXI/Dnhg1MAE4rbltxOOB+7lUduJbsxucZf2DUo3NuZMQguw62NBVKGAtqJ03XdSlcNtO6eq5rXbDMEMVGLbDzMN+kdHlwZaNwYXk=', 'base64')), |
There was a problem hiding this comment.
Does this address do the right thing?
There was a problem hiding this comment.
Yes, the lsig's address is 6Z3C3LDVWGMX23BMSYMANACQOSINPFIRF77H7N3AWJZYV6OH6GWTJKVMXY, and since the transaction's sender is different we should expect the signed transaction to contain a AuthAddr/sgnr field with the lsig's address.
This is the decoded expected txn g6Rs...:
{
"lsig": {
"l": "// version 1\nintcblock 1\nintc_0\n"
},
"sgnr": "6Z3C3LDVWGMX23BMSYMANACQOSINPFIRF77H7N3AWJZYV6OH6GWTJKVMXY",
"txn": {
"amt": 847,
"fee": 2680,
"fv": 51,
"gh": "JgsgCaCTqIaLeVhyL6XlRu3n7Rfk2FxMeK+wRSaQ7dI=",
"lv": 61,
"note": "ewzI",
"rcv": "UCE2U2JC4O4ZR6W763GUQCG57HQCDZEUJY4J5I6VYY4HQZUJDF7AKZO5GM",
"rekey": "GAQVB24XEPYOPBQNJQAE4K3OLNYTRYD65ZKR3OEW5TDOOGL7MDKABXHHTM",
"snd": "XMHLMNAVJIMAW2RHJXLXKKK4G3J3U6VONNO3BTAQYVDC3MHTGDP3J5OCRU",
"type": "pay"
}
}
algorotem
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you attempt to use the
signLogicSigTransactionfunction to make a LogicSig contract account sign a transaction whose sender is not the LogicSig's computed address, an error will be thrown. This means that sending transactions form an account rekeyed to a LogicSig is not possible.This PR fixes this issue by allowing non-delegated LogicSigs to sign transactions from any address, adding in the AuthAddr field to the signed transaction if necessary.