Begin migration to TypeScript #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…porting it into files
* Design TypeScript types to accommodate every transaction type
* Shorten transaction types names * Provide types for make transaction functions' arguments
…o TypeScript * Fix bug with `MustHaveSuggestedParamsInline` type
…keTxn.js` to TypeScript * Convert `base.d.ts` declaration file to `base.ts` to properly compile enums
…keTxn.js` to TypeScript
…s in `makeTxn.js` to TypeScript
* Convert `module.exports` to named exports
* Add Address type * Add encoded transaction types * Fix documentation for `SuggestedParams` * Fix unnecessary property in Transaction tests
* Provide better type info for the `_getDictForDisplay()` Transaction method * Remove unnecessary `.ts` extensions in imports * Undo inconsistent parameter renaming of `rekeyTo` in `makeTxn.ts`
* Add type definitions for MultisigMetadata
* Migrate `index.js` to TypeScript
jdtzmn
force-pushed
the
jacob/typescript-migration
branch
from
7e34167
to
17fa7b3
Compare
jasonpaulos
requested changes
Mar 18, 2021
jdtzmn
force-pushed
the
jacob/typescript-migration
branch
from
b02ff54
to
dbd51f9
Compare
Closed
jdtzmn
force-pushed
the
jacob/typescript-migration
branch
from
dbd51f9
to
3fc5303
Compare
jdtzmn
force-pushed
the
jacob/typescript-migration
branch
from
e8c8153
to
0cfd697
Compare
jdtzmn
force-pushed
the
jacob/typescript-migration
branch
from
0cfd697
to
b227d1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates TypeScript compilation into the build steps, and migrates the following files and directories to TypeScript:
src/transaction.jssrc/makeTxn.jssrc/encodingsrc/nacl/naclWrapper.jssrc/main.jsindex.jsIt also includes an example showing how to use TypeScript type definitions.
Closes #295.